265330 - Issues with Unread messages and Virtual Folders

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

First reported to me by Asa.

If I am inside a virtual folder. I cannot mark a message as read by clicking on
the  read/unread icon. It looks like it gets marked as read and then marked back
as unread again. I even see the folder count in the folder pane for the VF
changing and then changing back. 

Another thing that may be related. The new mail indicator (the red blat in the
folder pane next to the folder) goes off for your virtual folder which is fine.
But when I read the new message, I'm not seeing the new mail indicator go away
for that virtual folder. It does go away for the real account. This is for imap.
I wonder if the VF isn't listening for a particular notification that it should be.

Comment 1

[David :Bienvenu]

is this a single folder virtual folder, or a virtual folder that searches across
multiple folders? I tried this and it worked fine for me...

Comment 2

[Scott MacGregor]

for me at least.

IMAP spanning multiple folders

Comment 3

[Scott MacGregor]

asa may be seeing another variant:

"I mean that if I have a virtual folder that has unread messages, the folder
name is bolded in the folder/account pane, similar to a normal folder with
unread messages. When I read those messages, from either the virtual folder or
the real folder, the label for the virtual folder stays bolded as if it's still
got unread messages until I visit it and then some other folder.

steps:
1. have a virtual folder that's got unread messages.
2. read messages.
results:
see that the virtual folder is still bold.
expected: virtual folder label gets unbolded when it has no unread messages. "

Comment 4

[trix supremo]

also have another variance.

steps:
1. Inbox containing unread messages
2. search for unread messages.
3. save into a virtual folder.

result:
virtual folder is not in bold and displaying then number of unread messages.

expected:
virtual folder to be in bold and displaying the number.

Comment 5

[David :Bienvenu]

Attachment: fix clearing the new flag when last new message is read

this keeps track of the number of new messages in a virtual folder. I also had
to change GetNumNewMessages to ignore virtual folders when doing a deep count
(which the system tray does)

Comment 6

[David :Bienvenu]

Attachment: fix counts when opening a single folder virtual folder

Comment 7

[Scott MacGregor]

Comment on attachment 163022 [details] [diff] [review]
fix clearing the new flag when last new message is read

+      m_virtualFolder->SetNumNewMessages(numNewMessages - 1);

do we have to worry about numNewMessages being 0 here and setting a new message
count of -1?

Comment 8

[Scott MacGregor]

Comment on attachment 163023 [details] [diff] [review]
fix counts when opening a single folder virtual folder

isn't this:

 if (gCurrentVirtualFolderUri && gCurrentVirtualFolderUri != ""

the same thing as just checking for gCurrentVirtualFolderUri?