265532 - Missing Plugin placeholders missing from various pages

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[u88484]

Steps to reproduce:
1) Dont have flash and/or shockwave installed
2) Go to http://www.macromedia.com/shockwave/welcome/
3) The missing plugin placeholders are missing

Happens on various other sites as well..bug present for last couple of nightlys

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041021 Firefox/1.0

Comment 1

[Pavel Penaz]

I have flash installed but not shockwave. I can see the plugin bar on the top of
the page.

Comment 2

[u88484]

ya the bar shows, thats not what I'm talking about...I'm talking about the
placeholder box with the green puzzle piece icon is missing

Comment 3

[Thomas Bertels]

It seems to be a general bug in firfox 1.0 PR. You can see the same thing with
gif images in this page :
http://www.volvo300mania.com/forum/posting.php?mode=smilies.

Comment 4

[Aaron Leventhal]

Attachment: Simple test case

Comment 5

[Doron Rosenberg (IBM)]

jst: this is a aviary regression from the previous behavior.  Probably can be
considered a blocker.

Comment 6

[Johnny Stenback (:jst)]

Yeah, I think I've got a fix...

Comment 7

[Johnny Stenback (:jst)]

Attachment: Don't call CantRenderReplacedElement() for non-object plugin elements.

Comment 8

[Johnny Stenback (:jst)]

Attachment: ... and don't leak plugin error codes out of Reflow().

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 163463 [details] [diff] [review]
... and don't leak plugin error codes out of Reflow().

r+sr=dbaron, although the style thing should probably stay with the call to
CantRenderReplacedElement, assuming align="top", etc., do reasonable things to
the missing plugin icon.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 163463 [details] [diff] [review]
... and don't leak plugin error codes out of Reflow().

a=asa for aviary checkin.

Comment 11

[Johnny Stenback (:jst)]

Fixed on the aviary branch.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Er... Why is this the right fix?  Last I checked, CantRenderReplacedElement
actually showed the alt text for an <embed> or <applet> and all (using the "alt"
attribute for <applet>, see bug 71473 / bug 114641, and using the contents of an
<embed>).  Is there a reason we've decided not to show it?

Wouldn't the right fix be for CantRenderReplacedElement to leave the frame in
place when there is no alternate content or something, instead of just not
showing the site's desired fallback?

Comment 13

[Johnny Stenback (:jst)]

Wanna hack up a fix? I don't, not now.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Maybe, yes (once I find the time to pull a branch tree and all that jazz).  How
does the fix that was checked in behave with <applet> when java is disabled? 
Does it show the fallback content, or the placeholder?  Same for plugins
disabled in the Firefox preferences and <embed>.  That's the case that really
worries me; the other instances are edge cases that probably aren't hit much.

Comment 15

[Aaron Leventhal]

Since this is reopened I would like to indicate that this bug should apply for
both <embed> or <object> when there is no alternative placeholder content.

Comment 16

[Jeremy Hannon]

I am not sure if this is the right bug or not, but in 1.0 PR, clicking on the
alternate content of an OBJECT tag would bring up the search for plugin dialog.
 This shoud not be the case, because in some cases, the alternate content should
be clickable itself.  For example, having a link inside of the alternate content.

I was doing some work with using images instead of flash content and this became
very anoying that, if I clicked on the image, the box that would search for an
appropriate plugin would come up.

Comment 17

[Boris Zbarsky [:bzbarsky]]

> I am not sure if this is the right bug or not

It's not.  ;)

> clicking on the alternate content of an OBJECT tag would bring up the search

That's fixed.  See bug 264679.

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd fixed on linux fc2 using 2004102623-0.11 --now see the placeholder for
missing plugins.

Comment 19

[Aaron Leventhal]

Here's the real world example I was asked for of the <object> problem. I believe
it's broken here, but I don't have a machine to test with at the moment:
http://www.hyper.com/products/Professional/Tutorials/Rendering.htm

Mozilla trunk: works
Mozilla 1.73: broken
Aviary: broken?

You can't have Flash installed to show this problem, but you can always use the
simple test case attached to this bug to show it. There should be 2 puzzle piece
placeholders showing up in that example, not just 1.

Comment 20

[Marcia Knous [:marcia]]

Aaron: I tested this on Max OSX using today's build - Mozilla/5.0 (Macintosh; U;
PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1.

I removed the Flash plugin. The page you reference shows only 1 puzzle piece
placeholder in the example (as long as you are not counting the one that shows
up at the top of the page where it let you know you are missing plugins)

(In reply to comment #19)
> Here's the real world example I was asked for of the <object> problem. I believe
> it's broken here, but I don't have a machine to test with at the moment:
> http://www.hyper.com/products/Professional/Tutorials/Rendering.htm
> 
> Mozilla trunk: works
> Mozilla 1.73: broken
> Aviary: broken?
> 
> You can't have Flash installed to show this problem, but you can always use the
> simple test case attached to this bug to show it. There should be 2 puzzle piece
> placeholders showing up in that example, not just 1.

Comment 21

[Tracy Walker [:tracy]]

Only one place holder viewing the simple test case on Windows Firefox too.

Comment 22

[Aaron Leventhal]

Clarification:
* Testcase should have 2 placeholders
* Real world websites should have 1 (when flash is removed):
http://www.hyper.com/products/Professional/Tutorials/Rendering.htm

Comment 23

[Pavel Penaz]

First of all I do not see any place holder after clicking on the Simple testcase.

Secondly, can anyone confirm the following bug? When I middleclick this simple
testcase and then click on the "install missing plugin" button in the newly
opened tab, nothing happens.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0

Comment 24

[Worcester12345]

Is this bug now irrelevant with the yellow bar at the top of the browser?

Comment 25

[u88484]

The original bug was fixed but this was reopended because of
https://bugzilla.mozilla.org/show_bug.cgi?id=265532#c12 and the comments
following that

Comment 26

[u88484]

should this bug be closed and a new bug opened based on comment 12?

Comment 27

[Boris Zbarsky [:bzbarsky]]

Either way, but whatever you file make sure it depends on bug 1156