265548 - Virtual Folders don't remember the previously selected message

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

When opening a virtual folder, it doesn't seem to honor the "Remember the last
selected message" pref.

Is this easy to hook up David or do we have issues because we don't have all the
headers available to us when we first open the folder in order to select a message?

If it isn't easy we'll move this off the 0.9 radar.

Comment 1

[David :Bienvenu]

yeah, we probably don't have the headers at the point at which we try to select
the pereviously selected message.

Comment 2

[Scott MacGregor]

I took a stab at fixing this. Adding the code to select the previously displayed
message is easy. The problem is we end up changing the property for the last
displayed message on the folder being searched. There is no 'fake' folder for us
to set the property on.

As a result, when you load say your Inbox again, we end up selecting the last
message you viewed from your virtual folder on your Inbox and that got really
confusing. 

Comment 3

[Scott MacGregor]

Attachment: the fix for single folder virtual folders

Comment 4

[Scott MacGregor]

Comment on attachment 163900 [details] [diff] [review]
the fix for single folder virtual folders

David,
This fixes it for the single virtual folder case by consolidating some generic
scrolling code that we run after a folder is loaded into a single method
(ScrollToMessageAfterFolderLoad ) and then calling that after we are done
loading a virtual folder in searchBar.js.

I haven't tried to hook this up for cross folder virtual folders yet.

Comment 5

[Scott MacGregor]

fixed branch and trunk for the single folder virtual folder case. Enjoy Asa!

Comment 6

[Scott MacGregor]

David, you mentioned to me over AIM The other day that you thought there was a
call from our cross folder virtual folder internals out to javascript after the
virtual folder has been searched. Do you know where that call is? I didn't see
anything in nsMsgGroupedView::OnSearchDone.

If there is such a call then I'll look into fixing this bug for the cross
virtual folder case for 0.9 as well.

Otherwise we'll move the rest of this bug off the .9 radar since we got the 90%
case working (i.e. Asa :)).

Comment 7

[David :Bienvenu]

no, only for the single folder VF case, in onSearchDone in searchBar.js

for the cross folder VF case, I think it's OK to punt for now.

Comment 8

[Scott MacGregor]

punting

Comment 9

[John David Galt]

I don't know if it's within the existing scope of this bug, but the "back"
command ought to mean "go to the last-viewed message" -- not the message which
precedes the current one in the message pane (use "previous" for that) -- just
as it was in Netscape 4, 6, and 7.  The lack of this feature is a major
annoyance, especially since Mozilla is so slow to respond to commands (and
sometimes loses them entirely) that it's natural and frequent to type "n" twice
when one move is intended.

Comment 10

[Scott MacGregor]

punting again

Comment 11

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #7)
> no, only for the single folder VF case, in onSearchDone in searchBar.js
> 
> for the cross folder VF case, I think it's OK to punt for now.

Any updated thoughts, Bienvenu? (else this can be marked fixed)

Comment 12

[David :Bienvenu]

I don't remember if this was hard or not - I'll try to look.

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to Scott MacGregor from comment #0)
> When opening a virtual folder, it doesn't seem to honor the "Remember the
> last
> selected message" pref.

bienvenu, would you agree this is gone?  I can't reproduce (except that last remembered does not survive restarts)

Comment 14

[Wayne Mery (:wsmwk)]

Anyone who still sees a problem should file a new bug