Closed Bug 266857 Opened 18 years ago Closed 18 years ago

Cannot print more than once with a printer with non-Latin1 (e.g. Japanese) characters in its name

Categories

(Core :: Printing: Output, defect)

x86
Windows 98
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: masayuki, Unassigned)

Details

(Keywords: fixed-aviary1.0, fixed1.7.5, intl)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041029 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041029 Firefox/1.0RC1

I cannot print two times using Japanese named printer on Win9x.

Reproducible: Always
Steps to Reproduce:
1. Print any page using Japanese named printer.
2. Print again.
3.

Actual Results:  
The printer is not found.
The error message returned by OS.

Expected Results:  
No errors.
Comment on attachment 163966 [details] [diff] [review]
Patch

Please review it jungshik.
Attachment #163966 - Flags: review?(jshin)
Comment on attachment 163966 [details] [diff] [review]
Patch

Thanks for fixing it. 

Perhaps, we have to do tree-wide search for 'AssignWithConversion' and
'CopyASCIItoUTF16' to get rid of this kind of mistakes once and for all. Well,
with patches for firefox going in without a proper review (e.g. bug 266839), 
that'll be an endless 'battle'.

Btw, next time you make a patch, please make a diff at the top of the tree.
Attachment #163966 - Flags: superreview?(bzbarsky)
Attachment #163966 - Flags: review?(jshin)
Attachment #163966 - Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.7.x?
Flags: blocking-aviary1.0?
Keywords: intl
Summary: Cannot print two times by Japanese named printer → Cannot print more than once with a printer with non-Latin1 (e.g. Japanese) characters in its name
Comment on attachment 163966 [details] [diff] [review]
Patch

sr=bzbarsky if:

1)  You make printerNameA an nsDependentCString.

2)  You give printerNameA a name that makes sense (say "printerNameNative").
Attachment #163966 - Flags: superreview?(bzbarsky) → superreview+
> Perhaps, we have to do tree-wide search for 'AssignWithConversion' and

that's what I'm currently doing, but it's a slow process... eventually, I'll
remove AssignWithConversion. but mailnews is somewhat hard to fix while it's
using filespec, which has no utf16 path/leafname getter... and I'd kinda like to
avoid spreading NS_CopyNativeToUnicode around...
Comment on attachment 163966 [details] [diff] [review]
Patch

Jungshik, please check-in the patch.
Attachment #163966 - Flags: approval1.7.x?
Attachment #163966 - Flags: approval-aviary?
patch checked in to the trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
When this patch was checked in, were bz's comments addressed?
Yes, it was. Sorry I forgot to note that.
Comment on attachment 163966 [details] [diff] [review]
Patch

a=mkaply for 1.7.

Need to ping an aviary person
Attachment #163966 - Flags: approval1.7.x? → approval1.7.x+
fix checked into 1.7 branch (with bz's concerns addressed)

seems like it missed firefox 1.0 train. 
Keywords: fixed1.7.x
Comment on attachment 163966 [details] [diff] [review]
Patch

a=asa for checkin to aviary. Time is real short so this needs to land very soon
if it's going to make it.
Attachment #163966 - Flags: approval-aviary? → approval-aviary+
patch checked into aviary-1.0
Keywords: fixed-aviary1.0
Flags: blocking1.7.x?
Flags: blocking-aviary1.0?
You need to log in before you can comment on or make changes to this bug.