266857 - Cannot print more than once with a printer with non-Latin1 (e.g. Japanese) characters in its name

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041029 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041029 Firefox/1.0RC1

I cannot print two times using Japanese named printer on Win9x.

Reproducible: Always
Steps to Reproduce:
1. Print any page using Japanese named printer.
2. Print again.
3.

Actual Results:  
The printer is not found.
The error message returned by OS.

Expected Results:  
No errors.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 163966 [details] [diff] [review]
Patch

Please review it jungshik.

Comment 3

[Jungshik Shin]

Comment on attachment 163966 [details] [diff] [review]
Patch

Thanks for fixing it. 

Perhaps, we have to do tree-wide search for 'AssignWithConversion' and
'CopyASCIItoUTF16' to get rid of this kind of mistakes once and for all. Well,
with patches for firefox going in without a proper review (e.g. bug 266839), 
that'll be an endless 'battle'.

Btw, next time you make a patch, please make a diff at the top of the tree.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 163966 [details] [diff] [review]
Patch

sr=bzbarsky if:

1)  You make printerNameA an nsDependentCString.

2)  You give printerNameA a name that makes sense (say "printerNameNative").

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

> Perhaps, we have to do tree-wide search for 'AssignWithConversion' and

that's what I'm currently doing, but it's a slow process... eventually, I'll
remove AssignWithConversion. but mailnews is somewhat hard to fix while it's
using filespec, which has no utf16 path/leafname getter... and I'd kinda like to
avoid spreading NS_CopyNativeToUnicode around...

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 163966 [details] [diff] [review]
Patch

Jungshik, please check-in the patch.

Comment 7

[Jungshik Shin]

patch checked in to the trunk

Comment 8

[Mike Kaply [:mkaply]]

When this patch was checked in, were bz's comments addressed?

Comment 9

[Jungshik Shin]

Yes, it was. Sorry I forgot to note that.

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 163966 [details] [diff] [review]
Patch

a=mkaply for 1.7.

Need to ping an aviary person

Comment 11

[Jungshik Shin]

fix checked into 1.7 branch (with bz's concerns addressed)

seems like it missed firefox 1.0 train. 

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 163966 [details] [diff] [review]
Patch

a=asa for checkin to aviary. Time is real short so this needs to land very soon
if it's going to make it.

Comment 13

[Jungshik Shin]

patch checked into aviary-1.0