267560 - CheckCanChangeField in process_bug.cgi requests the bug owner, QA contact and reporter too many times

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

This function should request only once per bug, not for every field (assuming we
come here, which requires that the user hasn't editbugs privs and that the field
is modified).

The speed gain shouldn't be too high.

The code is:

if ($lastbugid != $bugid)

but $lastbugid is never updated!

Comment 1

[Frédéric Buclin]

Attachment: add $lastbugid = $bugid;

I think this is the only thing to do. Or is there something I missed?

Comment 2

[Frédéric Buclin]

Comment on attachment 164486 [details] [diff] [review]
add $lastbugid = $bugid;

I will try it on my installation, but this should be ok!

Comment 3

[Dave Miller [:justdave]]

And this infects 2.16 as well.  yay.  Good catch.

Comment 4

[Frédéric Buclin]

(In reply to comment #2)
> (From update of attachment 164486 [details] [diff] [review])
> I will try it on my installation, but this should be ok!
> 

OK, I didn't see any problem on my installation...

Comment 5

[Dave Miller [:justdave]]

This patch doesn't apply cleanly against the 2.16 branch, however.

Comment 6

[Frédéric Buclin]

Attachment: same patch, for the 2.16 branch

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 166509 [details] [diff] [review]
same patch, for the 2.16 branch

heh, gotta love it when a patch fails to apply because the surrounding
*comments* changed. :)	Ah, for a smarter 'patch' program. :)

Comment 8

[Vlad Dascalu]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.125.2.12; previous revision: 1.125.2.11
done

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.205.2.7; previous revision: 1.205.2.6
done

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.217; previous revision: 1.216
done