267601 - wrong icon displayed for rss posts when "grouped by sort" is selected

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Curtis Buys]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

When viewing a folder of RSS posts and NOT grouping the messages by the sort
criteria there is a post-like icon next to the subject of each post that looks
like a piece of paper pinned up.  When the new "Group By Sort" feature is
selected either from the View > Sort by menu or with the accesskey G the icon
displayed next to the subject of each post is the envelope icon used for mail items.

Reproducible: Always
Steps to Reproduce:
1. View an RSS feed's folder.
2. Press "G" or select from the View menu: Sort by > Grouped By Sort


Actual Results:  
Messages are now shown with the mail icon next to the subject, not the post icon.

Expected Results:  
Messages should still be shown with the post icon.

Comment 1

[Curtis Buys]

Attachment: Screenshot of RSS Post Icon when NOT "Grouped By Sort"

Comment 2

[Curtis Buys]

Attachment: Screenshot of RSS Post Icon with "Grouped By Sort" selected

Seeing this in the 0.9 release (20041103) -- Fresh install by installer, new
profile.  I first noticed this on a different machine with some of the first
nightlies (as .zip files) that included the message grouping feature.

Comment 3

[Scott MacGregor]

Attachment: the fix

Comment 4

[Scott MacGregor]

Comment on attachment 164610 [details] [diff] [review]
the fix

David, 
I noticed a lot of stuff in nsMsgDBView::Open besides just setting the message
type atom that looked like code we'd want called when opening a grouped view. 

If you see something in nsMsgDBView::Open that we don't want getting called 
for a grouped view, then I can break out the stuff we do want in a separate
method.

Also, should we be calling through the grouped view's parent class
(nsMsgSearchDBView) Open method and let that call nsMsgDBView::Open instead?

Comment 5

[David :Bienvenu]

Comment on attachment 164610 [details] [diff] [review]
the fix

if you do this, I don't think you need stuff up to PersistFolderInfo
either...since it's in nsMsgDBView::Open.

the grouped view's parent  is nsMsgThreadedDBView, and we definitely don't want
to call that.

Comment 6

[Scott MacGregor]

Comment on attachment 164610 [details] [diff] [review]
the fix

right you are

Comment 7

[Scott MacGregor]

Attachment: better fix

Comment 8

[Scott MacGregor]

Attachment: 3rd time is a charm

Comment 9

[David :Bienvenu]

Comment on attachment 164618 [details] [diff] [review]
3rd time is a charm

sorry I wasn't clearer last time...

Comment 10

[Scott MacGregor]

fixed branch and trunk

Comment 11

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2004120106-0.9 on linux fc2. (n/a on mac, btw, since that
theme doesn't have icons for messages in the thread pane.)