268099 - filepicker buttons are too wide

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Andrew Schultz]

With linux trunk 2004110506, the filepicker's buttons for up, home and create a
directory are too wide (about 2-3x too wide).  Backing out bug 267498 and bug
265165 fix the problem.

Dom Inspector attributes the extra width to the button's label, which is 28px
(without bug 265165, it was 0px)

Comment 1

[Felix Miata]

In same gtk1 build ID I see only too wide home & up buttons. Where is create
directory button supposed to be? Only labels I see are the tooltips.

Comment 2

[Andrew Schultz]

The create directory button should be next to the home button.  I was also using
the gtk1 build.  This probably does not affect the gtk2 build since it uses the
gtk2 filepicker.

Comment 3

[[e-mail]]

The create directory button is hidden if you are opening files.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This fixes it.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 164982 [details] [diff] [review]
fix 

Fixes a regression from bug  265165.

Maybe XUL layout-based min-size shouldn't override the CSS max-size? I wish we
had hyatt's flexbox CSS draft

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 164982 [details] [diff] [review]
fix 

r+sr=bzbarsky, but I agree that this whack-a-mole is silly.  There's a pretty
fundamental incompatibility here between the flexbox stuff and CSS...

Comment 7

[Felix Miata]

*** Bug 269362 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

Robert, you going to check this in?  ;)

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sorry, I lost the review granted email (machine death) and forgot about it.
thanks for the reminder :-)

Comment 10

[[e-mail]]

Comment on attachment 164982 [details] [diff] [review]
fix 

>+  min-width: 0%; // don't let XUL layout min-size override our max-width setting
These need CSS-style comments, surely?