268607 - greprefs/all.js contains references to mozilla chrome

Status: RESOLVED DUPLICATE of bug 297759

(Core :: Preferences: Backend, defect)

Description

[Mike Hommey [:glandium]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.7.5) Gecko/20041109 Firefox/1.0 (Debian package 1.0-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.7.5) Gecko/20041109 Firefox/1.0 (Debian package 1.0-1)

bingreprefs/all.js contains references to mozilla chrome, such as
chrome://navigator-platform/locale/navigator.properties.

That makes general.useragent.contentlocale contain a wrong value, since it is
not overriden in bin/defaults/pref/firefox.js. Most of the others are overriden,
so it's not really a problem in firefox, but still, it's incoherent.

An other culprit is general.useragent.locale which is overriden to a static
value (in firefox-l10n.js), being the one of the bundled locale in localized
distributions.
It should just be chrome://global/locale/intl.properties, so that running
firefox in an other locale (installing locales as extensions and using the
-UIlocale command-line argument) will set the general.useragent.locale accordingly.

Please find a patch attached.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch to change these wrong values to actual values

Comment 2

[Nickolay_Ponomarev]

It is not that easy. all.js is shared between gecko applications
(seamonkey/firefox/thunderbird), so you can't just replace values in it. What
needs to be done is either make Firefox/Seamonkey/others really share the prefs
(ie, use a chrome:// URIs common to all apps) or move the prefs from all.js to
app-specific prefs files.

btw, patches should be against cvs (the files you are editing are pre-processed
at build time)

Comment 3

[Nickolay_Ponomarev]

dang. sorry for the extra mail

Comment 4

[timeless]

Comment on attachment 165298 [details] [diff] [review]
Patch to change these wrong values to actual values

this patch is bogus and will break things.

note that the prefs are generally clobbered in firefox.js and thunderbird.js
(while that's not ideal, breaking seamonkey isn't acceptable either).

Comment 5

[Reed Loden [:reed]]

Mike, how about an updated patch to address the review comments?

Comment 6

[Mike Hommey [:glandium]]

Won't that be obsoleted by suiterunner ?

Comment 7

[Mike Hommey [:glandium]]

The exact same patch was applied in bug 297759.