26996 - </font><br><font> not fixed by temporary bug-24186 fix {ll} {compat}

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Hixie (not reading bugmail)]

The fix for bug 24186 solved the common case of

   <p> <font size="1">
     bla bla <br> bla bla <br> bla bla 
   </font> </p>

...but does not change our behaviour for the case of:

   <p> 
     <font size="1"> bla bla </font> <br>
     <font size="1"> bla bla </font> <br>
     <font size="1"> bla bla </font> <br>
   </p>

This can be seen on:
   http://home.netscape.com/

The long-term fix for bug 24186 would NOT automatically fix this!!! ...because
the <br> would have an inherent line-height (it is an empty inline element, see
also bug 4247 and bug 2590). On the long term, we will need to make sure that
when we ignore the line-height of blocks we also ignore the line-height of 
empty inline elements. (Woohoo, another quirk, great.)

Note: If no other high-profile sites can be found which have this form of 
markup, then it may be better just to get home.netscape.com to change their
page layout to use one font element with the <br>s inside...

See this test page:
   http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/font-and-br.html

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I expect constructions like this are common.  Note that there is another bug,
somewhere, about line-height: 0 and <BR>, I think.

Comment 2

[Hixie (not reading bugmail)]

Do you mean bug 15428, "line-height values less than 1 are wrong"?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: interesting testcase

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: same testcase, without whitespace in large-font areas

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I have a fix for this bug (but not bug 26998, so there are still problems with
the first attachment above, and also some problems with the first two tests,
which test bug 15428).  Assigning to self.

Comment 6

[ekrock's old account (dead)]

How many examples are there of this causing problems on the Top 100? (I bet 
there are others besides netscape.com.) Unless such examples are rare in the 
top 100, this bug should be nominated for beta1 status.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2000-02-14 20:26PDT.

Comment 8

[Hixie (not reading bugmail)]

The truth comes out. David is, in fact, a genius.

Comment 9

[buster]

clearly.  I had the pleasure of reviewing the code, and it was all very well 
written and thoughtfully commented.  David, want to teach a class on software 
engineering skills?  I know a few people who could use a refresher course!