270023 - DOM Node view should show namespace uri of attributes

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

currently, it only shows the qualified name and the value of an attribute;
showing the namespace uri too would be useful (it should be at least available
in the column picker)

Comment 1

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.1

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 197688 [details] [diff] [review]
version 0.1

shrug.	ok.

Comment 3

[Vidar Haarr (not reading bugmail)]

biesi: Do you know if DOMi requires sr? If not, could you help me check this in?

I wasn't very reassured as to the quality of the patch by that "shrug" :-P Could
it be done otherwise?

Comment 4

[Alex Vincent [:WeirdAl]]

Inspector typically does require sr.

Comment 5

[[e-mail]]

Comment on attachment 197688 [details] [diff] [review]
version 0.1

>+          <treecol id="colNamespaceURI" hidden="true" label="namespaceURI" persist="width,hidden,ordinal" flex="1"/>
The style of dom.xul is to have the hidden="true" attribute after the label attribute, plus it also puts this column in between the node name and value by default; sr=me with these fixed.

caillon's comment suggests that he's not convinced that the namespace uri is necessary while I wonder whether we should add the local name and prefix too.

Comment 6

[Shawn Wilsher :sdwilsh]

Attachment: v.2

r=caillon, sr=neil

I only fixed the bit rot and line wrapped at 80 characters.

Comment 7

[Shawn Wilsher :sdwilsh]

Checked in by timeless:
patch by [e-mail] r=caillon sr=neil

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

reopening, the patch as checked in didn't have sr. note "sr=me with these fixed."

Comment 9

[[e-mail]]

(In reply to comment #6)
>I only fixed the bit rot and line wrapped at 80 characters.
When instead you should have addressed the review comments :-P

Comment 10

[Shawn Wilsher :sdwilsh]

(In reply to comment #9)
> When instead you should have addressed the review comments :-P

*hangs head in shame*

Not sure how I missed that...

(In reply to comment #5)
> caillon's comment suggests that he's not convinced that the namespace uri is
> necessary while I wonder whether we should add the local name and prefix too.

The nodeName, which is currently displayed is (as I recall) actually composed of the both the prefix and the local name like so:
{prefix}:{local name}

> plus it also puts this column in between the node name and value by default

I can't fix this because I'm not sure what you mean.  The column is the left most column and is on top of the list of columns to hide/show.  Do you mean you want it between nodeName and nodeValue?

Comment 11

[Shawn Wilsher :sdwilsh]

Closing - will be resolved with Bug 348668 as per Comment 4 from Neil.