348668 - attribute "nodeName" column needs to be split up in "prefix" and "localName" columns

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[mozilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

For example "bs:nonsense" as a nodeName of an attribute, would be a lot more readable as "bs" "nonsense" because of the layout improvement with 2 columns.
Plus it would show Mozilla is more likely to actually interpret the namespaces correctly, making the content coder more confident, as namespaces are still often interpreted wrong in general.
When introducing attribute sorting (another bugreport on its way) this would also provide another aspect to sort on.

Reproducible: Always

Comment 1

[Shawn Wilsher :sdwilsh]

I do believe that Neil made a comment about us doing this in the past.

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Why not...this is trivial, and seems beneficial (if I'm wrong, timeless will tell me anyway).

I cleaned up the formatting for the remaining column as well.  Neil - since this is the same file there is still Bug 270023 that is awaiting your comment.  I can fix that in this patch, or I can fix it there.  Regardless, I'm waiting on you :)

Comment 3

[Alex Vincent [:WeirdAl]]

patch looks okay to me, unofficial r=ajvincent.

Comment 4

[[e-mail]]

(In reply to comment #2)
>Neil - since this is the same file there is still Bug 270023 that is
>awaiting your comment. I can fix that in this patch, or I can fix it there.
Fixing it here will be fine.
As for the comment, I noticed that in dom/dom.xul the default column order is nodeName, localName, prefix, namespaceURI, nodeType, nodeValue, although maybe we should change that ordering to something more sensible.
Finally you should note that hiding the nodeName column by default won't affect people who have already hidden and shown it again.

Comment 5

[[e-mail]]

(In reply to comment #4)
>Finally you should note that hiding the nodeName column by default won't affect
>people who have already hidden and shown it again.
Sorry, I hadn't noticed that you're removing it. I'm not sure you should.

Comment 6

[[e-mail]]

Comment on attachment 233705 [details] [diff] [review]
v1.0

Although I'd prefer to see nodeName restored.

Comment 7

[Alex Vincent [:WeirdAl]]

personally, I'd agree with Neil, about leaving nodeName.  But that's up to you, I guess.

Comment 8

[Shawn Wilsher :sdwilsh]

Alright, I'm looking at Bug 212789 which appears would allow for horizontal scrolling of trees.

Assuming that works, I'll put back nodeName, and then have prefix and localName be  hidden, as well as placing namespaceURI after nodeValue.  This will please everyone I think and allow for scrolling.

Comment 9

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

r=timeless, sr=neil

Added nodeName back and reordered as per Comment 4, and opened new bug to address the "right" ordering (Bug 348764).

Comment 10

[Peter Kasting]

Checked in to trunk.

/mozilla/extensions/inspector/resources/content/viewers/domNode/domNode.xul 1.16