270079 - Mozilla can not print the URL in the header and footer.

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Leon Sha]

Normally you can print the URL in the header.
But after you print an email, you can never print the URL in the header and footer.

Comment 1

[Leon Sha]

Attachment: Patch

Comment 2

[Leon Sha]

Comment on attachment 166418 [details] [diff] [review]
Patch


>-  if (!mGlobalPrintSettings) {
>-    CreatePrintSettings(getter_AddRefs(mGlobalPrintSettings));
>-    NS_ASSERTION(mGlobalPrintSettings, "Can't be NULL!");
>-  }
>+  CreatePrintSettings(getter_AddRefs(mGlobalPrintSettings));
>+  NS_ASSERTION(mGlobalPrintSettings, "Can't be NULL!");

Change this will not change the performance, since this function will only be
invoked two times, when browser start printing/preview and when mailnews start
priting/preview.

Comment 3

[Darin Fisher]

Leon, I think you should find someone with more experience in the printing code
to review this.  I can provide superreview after you have a review from a module
owner or peer.  http://www.mozilla.org/owners.html might help you find an
appropriate review; however, in my experience it is a bit out-of-date.  You
could also try asking on #developers at irc.mozilla.org

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note that the assertion is false in out-of-memory cases.  Then the global print
settings _will_ in fact be null....

Comment 5

[Leon Sha]

(In reply to comment #4)
> Note that the assertion is false in out-of-memory cases.  Then the global print
> settings _will_ in fact be null....

So what is you suggestion?

Comment 6

[Leon Sha]

Attachment: Patch with bz's comments

Comment 7

[Ian Graham]

*** Bug 242225 has been marked as a duplicate of this bug. ***

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 168382 [details] [diff] [review]
Patch with bz's comments

+  NS_ASSERTION(mGlobalPrintSettings, "Can't be NULL!");

I think this should be
NS_ASSERTION(NS_FAILED(rv) || mGlobalPrintSettings,

so we don't get the assertion if out of memory

r+sr=roc with that

Comment 9

[Leon Sha]

Attachment: Patch with roc's comments. Ready to check in.

Comment 10

[Ginn Chen]

Checking in gfx/src/nsPrintOptionsImpl.cpp;
/cvsroot/mozilla/gfx/src/nsPrintOptionsImpl.cpp,v  <--  nsPrintOptionsImpl.cpp
new revision: 1.71; previous revision: 1.70
done

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This may cause bug 275387.