27027 - Disable Wallet menu items, dialogs & prefs for beta1

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[sairuh (rarely reading bugmail)]

summary sez it all. i couldn't find a unique bug on this, so here it is. i don't
know if the decision is to just grey them out, precede w/dots (menus only), or
to remove them. (dialogs would need to be disabled.) here are where they show up
in the browser.

nbaca, let me know if there are *additional* places in mail which would be
similarly affected. (if it's the same items, then nevermind ;-)

menu items to remove/disable/grey out/precede w/dot
---------------------------------------------------
Tasks > My Wallet > Safe Form Fill
Tasks > My Wallet > Quick Form Fill
Tasks > My Wallet > Capture Form
Tasks > My Wallet > Wallet Contents

dialogs to disable
------------------
Wallet Editor dialog
Safe Form Fill dialog

preferences to disable/remove/grey out
--------------------------------------
Advanced > "Save form data when submitting" checkbox
Advanced > Wallet > entire Wallet section ("server for wallet tables" text field
& "View Wallet entries" button)

Comment 1

[sairuh (rarely reading bugmail)]

needed for beta1. also might affect other bugs, so added 'meta' so that others
could add dependencies where needed.

Comment 2

[leger]

Putting on PDT+ radar for beta1.

Comment 3

[lchiang]

Would this affect the single sign-on for mail passwords?

Comment 4

[Paul MacQuiddy]

No, you are confusing wallet (autofill) with single-signon, which is very common :-)

Single-Signon deals solely with passwords, wallet (autofill) deals with
capturing common user data (addresses, e-mail address) and allowing users to
'auto-fill' them in at other sites with similar forms.

Comment 5

[Stephen P. Morse]

Down but not out!  You can bring it back for development and testing 
purposes very easily by including the following line in your prefs.js file:

   user_pref("wallet.enabled", true);

And it can be brought back in the build itself by changing the following line in 
mozilla\modules\libpref\src\init\all.js from false to true:

   pref("wallet.enabled", false);

Comment 6

[sairuh (rarely reading bugmail)]

verif blocked by bug 28083.

Comment 7

[sairuh (rarely reading bugmail)]

while i cannot completely verify this bug due to prefs blocker #28083, i did
notice that on Mac the wallet menu items are still listed [2000021808]:

Tasks > Autofill > Safe Form Fill --should be removed
Tasks > Autofill > Quick Form Fill --should be removed
Tasks > Autofill > Capture Form --should be removed
Tasks > Autofill > Wallet Contents --should be removed

not a problem on NT or linux (their menu items have been appropriated disabled).

Comment 8

[sairuh (rarely reading bugmail)]

verifying this...however, i can still see the wallet-related items in the menu
on mac. 2000022308. i'll open a separate bug for that.

Comment 9

[Andreas Otte]

After the beta1 branch has happend, isn't it finally time to enable the wallet
feature again by default?

Comment 10

[Stephen P. Morse]

YES, YES, YES!!!.  Consider it done.