28083 - unable to view Advanced > Password Manager panel

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[sairuh (rarely reading bugmail)]

saw this when using comm bits on linux [2000021609] and mac [2000021608], but
not a problem on winNT non-comm bits [2000021608]. i wouldn't think that comm vs
non-comm would make a difference, but...

to repro, open up the Preferences dialog and select the Advanced > Password
Manager category. result: the panel doesn't appear. on linux it's black (due to
bug 28078), and on mac it just displays the previous panel contents (no content
change).

Comment 1

[sairuh (rarely reading bugmail)]

nominating for beta1.

Comment 2

[Phil Peterson]

PDT+

Comment 3

[Stephen P. Morse]

Sarah, since I don't have a commercial build (nor a mac build), can you run the 
following test for me.  In the chrome directory under pref/content you'll see 
the file pref-wallet.xul.  In that file you see the following line:

     <titledbox orient="vertical" id="walletArea" style="display: none;">

Change that to read:

       <titledbox orient="vertical" id="walletArea">

Let me know if that makes the problem disappear.

Comment 4

[matt]

This looks like it's not finding
an entity that is there.  

Comment 5

[sairuh (rarely reading bugmail)]

steve, i tried the above workaround (using 2000021708 opt comm bits on linux),
restarted seamonkey... and still unable to view the Password Mgr panel in Prefs.

Comment 6

[Stephen P. Morse]

Are there any messages on the console at this time?  Or does mac not have a 
console?

Comment 7

[sairuh (rarely reading bugmail)]

mac doesn't have a console... but this is what i get from the console on linux
(not much) --mind you, this is after i've modified pref-wallet.xul per the above
(and additional instructions to replace <titledbox [etc]> with <html:fieldset>
tags).

nsWebShellWindow::NS_DEACTIVATE
*** going to save page data for tag: pref-appearance
*** newURL: chrome://pref/content/pref-wallet.xul
got a request

Comment 8

[matt]

This is because we now need to change
the dtd file in the ns tree.
It is not finding the entity signonEnabledCheck.label.
Actaully this file is no longer needed since we are not
refering to netscape anywhere in the the wallet code.

Solution:
Steve you can either check in your new dtd file here in the NS tree
or Ben you can back out this file since we
are not refering to netscape.

Comment 9

[Stephen P. Morse]

I've checked in my new dtd files into the mozilla tree.  How do I get them into 
the netscape tree?

Comment 10

[matt]

just check them in the ns tree.
Do you have a build?

Comment 11

[Stephen P. Morse]

No, I don't have an ns build.  But from our e-mail exchange that we just had, it 
appears that the correct solution is not to check more stuff into the ns tree 
but rather to remove stuff that duplicates the mozilla tree.  Am I right?

Comment 12

[Stephen P. Morse]

There's nothing more I can do with this bug.  It looks like the solution, as 
described by matt, is to remove the duplicated pref-wallet.dtd module from the 
ns tree.  Reassigning to ben to remove it.

Comment 13

[sairuh (rarely reading bugmail)]

hunh, as of today's [2000021808] opt comm bits, this doesn't work in winNT
either. updating summary, removing pp keyword.

Comment 14

[Stephen P. Morse]

Sarah, can you tree removing the file pref-wallet.dtd from the 
chrome://pref/locale/en-us directory and replacing it with the equivalient file 
from a non-commercial build?  Let us know if that fixes the problem.

Let me know if you don't have the file from the non-commercial build and I'll 
e-mail it to you.

Comment 15

[sairuh (rarely reading bugmail)]

steve, i installed the mozilla [non-comm] bits on linux (also 2000021808), and
sure enough, i can bring up Advanced > Password Manager.

Comment 16

[Stephen P. Morse]

Correct fix is to remove pref-wallet.dtd from commercial tree as mentioned 
above.  But that involves makefile changes as well.  So the safest fix at this 
time is to overwrite the commercial version of the file with the mozilla 
version.  I did this and checked it in.

I presume somewhere else is a bug report about removing duplicate files between 
the two trees (if there isn't, there should be).

Comment 17

[sairuh (rarely reading bugmail)]

verif fixed using opt comm bits [2000022308] on linux, mac (and winNT).