270706 - Unable to manage identities when signature file is not on given path

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Phil Pishioneri]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Thunderbird version 0.9 (20041103)

Imported entire profile from Mozilla 1.8a4.

Attempting to "Manage Identities..." on an account which has multiple identities
fails (button appears to do nothing).  Checking the javascript console, I see
that this error gets logged when I click the button:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIMsgIdentity.signature]"  nsresult:
"0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame ::
chrome://messenger/content/am-identity-edit.js :: saveIdentitySettings :: line
145"  data: no]

The existing identities are still usuable in Message Composition.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Reporter, could you test it again with a current nightly build? This error
should have been fixed and is not visible anymore. If it's working for you, this
bug could be closed as WFM.

Comment 2

[Niko Lappalainen]

I have the same problem. 

1. Open Tools -> Account Settings...
2. Push Manage Identities... on the default account and nothing happens.

Reading this bug report I could find the following Javascript error:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIMsgIdentity.signature]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://messenger/content/am-identity-edit.js :: saveIdentitySettings :: line 199"  data: no]


Thunderbird version 1.5.0.5 (20060719)
Mac OS X 10.4.7 build 8J2135 (Intel)

Reproducible: Always


Note: Manage Identities opens without error with other accounts but not with the default account. The solution cannot be to delete the account and redo everything.

Comment 3

[Niko Lappalainen]

Replying to myself, the problem is related to a deleted signature file.

I had configured a signature text file and had later moved it to another place. After that Thunderbird did not give an error about the missing file nor could it open the Manage Identities dialog. It just stayed mute.

Comment 4

[Phil Pishioneri]

I had fixed this myself by modifying my identities so that I didn't get the error.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please don't resolve this bug as WFM while it's working for you after the update of your identity.

Does it still occur when you move your signature again? The identity dialog has to be opened although when the signature doesn't exist anymore.

@Niko: Does the path of your signature point to an existing directory?

Comment 6

[Frank Wein [:mcsmurf]]

Confirming based on the comments here and a report of an user on IRC having the same problem.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This WFM with Thunderbird version 2.0pre (20070309) on Mac OS X. Reporter can you please test again if it still happens for you? Please also run in Safe Mode or deactivate all extensions.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I tested again and now I can reproduce this issue with version 2.0.0.4pre (20070429).

Scott, does it have the priority to be added to your meta upgrade bug?

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: patch v1.0

Only set the signature if the given path really exists. Otherwise fall back to none. It also fixes the call of exists() in GetSigFolder.

Comment 10

[Phil Pishioneri]

As I wrote in comment 4, I (reporter) can no longer duplicate this problem.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #10)
> As I wrote in comment 4, I (reporter) can no longer duplicate this problem.

Although you reported that bug you are not the only person who is affected by this issue. It's still visible if the signature file is not on the given path. It's a bug and has to be fixed.

Comment 12

[Phil Pishioneri]

(In reply to comment #11)
> (In reply to comment #10)
>
> Although you reported that bug you are not the only person who is affected by
> this issue.

Yes, but repeatably asking me to test isn't going to help any. I don't use any signatures, and don't recall how I modified my profile in comment 4.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 263357 [details] [diff] [review]
patch v1.0

This patch checks if a signature really exists on the given path. Otherwise you are unable to manage identities on Mac OS X.

David, I accidentally made this patch against the 1.8 branch. But there was no change of the code in saveIdentitySettings on the trunk. If you wish a patch against the trunk I could deliver one.

Comment 14

[David :Bienvenu]

Comment on attachment 263357 [details] [diff] [review]
patch v1.0

looks good, thx. I'll figure out how to land this.

Comment 15

[Nickolay_Ponomarev]

Checking in am-identity-edit.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-identity-edit.js,v  <--  am-identity-edit.js
new revision: 1.12; previous revision: 1.11
done

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a5pre) Gecko/20070511 Thunderbird/3.0a1 ID:0000000000 [cairo]

Comment 17

[Adam Guthrie]

Henrik, have you considered asking for branch approval on the patch? It's a pretty trivial fix, and it seems like enough people are hitting this that it'd be worth fixing for 2.0.0.x.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 263357 [details] [diff] [review]
patch v1.0

Simple fix which gives back the possibility to edit identities when sig file is missing. Asking for approval 1.8.1.5.

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Adam, where do you see that a lot of people are seeing this? I wasn't able to reproduce it under Windows and Linux. Are this OS also affected or do you have more Mac OS users?

Comment 20

[Justin Scott [:fligtar]]

I've been running into the bug for a while now and couldn't figure out what the problem was. I asked Adam today and he figured out that even though the signature checkbox was unchecked, it was still trying to load my old signature file and I had to re-check, clear the textbox, and un-check to open the dialog.

Adam said it was Mac OSX only earlier I think, but I'm sure quite a few people have run into this problem.

Comment 21

[Scott MacGregor]

Comment on attachment 263357 [details] [diff] [review]
patch v1.0

a=mscott for 1.8.1.5

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Using new keyword for checkin-needed status.

Comment 23

[Nickolay_Ponomarev]

Except you're supposed to keep the special instructions you cleared from the whiteboard. I for one use it to filter away the bugs to be checked into the branch.

Comment 24

[Karsten Düsterloh]

Landed on MOZILLA_1_8_BRANCH.

Comment 25

[Adam Guthrie]

Verified FIXED using version 2.0.0.5pre (20070710) on Mac OS X 10.4.10. Thanks again for the fix, Henrik.