Open Bug 303545 Opened 17 years ago Updated 1 year ago

[Meta] Javascript strict warnings and errors (Thunderbird)

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: whimboo, Unassigned)

References

(Depends on 2 open bugs)

Details

(Keywords: meta)

Attachments

(1 file)

There will be a lot of that bugs...
Assignee: mscott → hskupin
Depends on: 252247
No longer depends on: 314722
Depends on: 315653
Depends on: 338958
No longer depends on: 338958
Depends on: 241251
Depends on: 349690
Depends on: 361865
Depends on: 270706
Depends on: 351064
Status: NEW → ASSIGNED
Summary: [Meta] Javascript strict warnings and errors → [Meta] Javascript strict warnings and errors (Thunderbird)
Keywords: meta
Depends on: 364123
Depends on: 333607
Depends on: 366255
Depends on: 368506
Depends on: 361702
Depends on: 370904
Depends on: 270563
Depends on: 374027
Depends on: 347994
No longer depends on: 374027
Depends on: 374101
Depends on: 365545
Depends on: 256447
Depends on: 375381
Depends on: 371174
Depends on: 201941
QA Contact: general
Depends on: 380406
Depends on: 381797
Depends on: 364817
Depends on: 231923
No longer depends on: 361865
Blocks: 296661
No longer depends on: 375381
I believe we don't need an explicit assignee for this bug.
Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Depends on: 787794
No longer depends on: 231923
Depends on: 826732
Depends on: 890058
Depends on: 1490448

|make mozmill| is gone since December 2019.

We now have mochitest for TB.

I picked up Javascript errors and warnings from the mochitest local run of FULL DEBUG version of TB.
The lines are plenty and I believe there are real errors, which I am going to file one by one hopefully in my spare time, but I hope someone will take a look at the listing and file a bugzilla entriy or two on their own.
The errors are simply too many for one individual to figure out.

The number at the beginning of each line is the frequency of occurrences.

There are some duplicates (I tried to make sure that we do not miss bugs/warnings.)

Also, there is a frivolous false positive.:
2 "/REF-COMM-CENTRAL/comm-central/mozilla/toolkit/devtools/deprecated-sync-thenables.js",

But the list should be a good start for bug hunting and already, I found a possible repeatable smoking gun to solve either bug 944194 or bug 1559267.

I am doing this to make sure my local patches won't break TB in undesirable way, but I am afraid that we need to clean up the current state in the first place. :-(

Depends on: 1634464
Depends on: 1105713

The following bugzilla may not be strictly speaking
a Javascript error/warning, but it certainly mentions head.js. So I added the dependency to it.
Bug 1105713 Fix warnings "Chrome file doesn't exist head.js" in tests
(Or should I create TB Meta entry for mochitest to assemble mochitest errors/warnings. |make mozmill| is gone and some bugzilla entries reported
under it are gone for now?)

I feel I should open a new META Thunderbird mochitest warnings/errors.
(This bugzilla is only for JavaScript-related ones and 15 years old.)

What do people think?

Flags: needinfo?(vseerror)

(In reply to ISHIKAWA, Chiaki from comment #4)

I feel I should open a new META Thunderbird mochitest warnings/errors.
(This bugzilla is only for JavaScript-related ones and 15 years old.)

Take this with a grain of salt because I don't deal with these issues ...

I suspect, yes, create a new meta in the General component. But note we have the test infra component which doesn't have many bugs. If that component truly is only for infra, and not actual tests, then I guess it makes sense that it it does not have many bugs.

Flags: needinfo?(vseerror) → needinfo?(rob)

Geoff is our Test module owner, I'll defer to him.

Flags: needinfo?(rob) → needinfo?(geoff)

It's not really a bug in the tests or the infrastructure if the warnings are coming from real code. So I'd say General is the better component.

It'd be nice to see some of this stuff fixed, but only if it's actually getting fixed. Otherwise it's just more noise.

Flags: needinfo?(geoff)
You need to log in before you can comment on or make changes to this bug.