Closed Bug 27161 Opened 25 years ago Closed 25 years ago

need a way to get to shell object from content

Categories

(SeaMonkey :: UI Design, defect, P2)

Product:
SeaMonkey
Component:
UI Design
Platform:
x86
Windows NT
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: slamm, Assigned: travis)

References

Details

(Whiteboard: [PDT+] will verify when 27162 is fixed) 

Need this for the Sidebar to be able to retarget links.
Blocks: 27162
Sidebar needs this for beta1 so that Netcenter can be consistent with how it
targets the urls. Without this, we will not only mess up Netcenter, but also
third parties that develop their own panel.
Keywords: beta1
Ugh.  OK, another M14.  Can the PDT folks mark this PDT+ soon?
Priority: P3 → P2
Target Milestone: M14
probably a dup of 27876
Whiteboard: [PDT+]
*** Bug 27876 has been marked as a duplicate of this bug. ***
My part on this bug is pretty much done.  This is waiting on work from buster 
for the ability to get to the innerframe's contents.  I'm flipping this bug to 
buster for now.  He can flip it back to me once he has added that 
functionality.  I will then finish testing the feature and make sure it all 
works.
Assignee: travis → buster
Whiteboard: [PDT+] → [PDT+] 2/25 for my part, unknown extra work from travis
Buster: If I believe the whiteboard, you are done, and need to pass this on to 
Travis.  Is the whiteboard up to date? Are you done?

Thanks,
Jim
updated whiteboard.  travis, troy, hyatt, and I are going to nail this 3/2
Whiteboard: [PDT+] 2/25 for my part, unknown extra work from travis → [PDT+] 3/2 for my part, unknown extra work from travis
what we decided to do was add interfaces to the pres shell, so that we don't 
expose nsIFrame. the pres shell holds the assocation between an nsIContent 
and an nsISupports, which in the normal case will be a docshell.  
this initial implementation does all the right things, but we really should move 
the docshell creation/association calls out of nsFrameFrame.cpp and into 
nsCSSFrameConstructor.cpp.
submitting a new bug for that cleanup work...
travis, reassigning to you.  if you have more work to do associated with this 
bug, go for it.  otherwise, mark it fixed.
Assignee: buster → travis
Summary: iframe needs to be able to get DocShell. → need a way to get to shell object from content
Whiteboard: [PDT+] 3/2 for my part, unknown extra work from travis → [PDT+] fix in hand
I have about 10 minutes worth of work to do once you land your changes into the 
tree.  You have approval to do that now?
Fix has been checked in.  You can now get the docShell from the iframe.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I guess slamm still has to do some work in the sidebar to take advantage of 
this, since links are still opening by default in the sidebar instead of in the 
main browser window. I marked 27162 beta1.
Whiteboard: [PDT+] fix in hand → [PDT+]
Yes, I still need to make changes to get the sidebar working with this.
Whiteboard: [PDT+] → [PDT+] will verify when 27162 is fixed
verified this with travis
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.