272005 - Remove toggle sidebar shortcut (F9) for mac

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Stefan [:stefanh]]

The F9 key is used by Exposé in Panther (10.3). See
http://www.apple.com/macosx/features/expose/. It probably work in pre-Panther
versions, but I suggest we remove it anyway.

Comment 1

[Stefan [:stefanh]]

Attachment: Simple one-liner, removes F9 for mac

Comment 2

[Stefan [:stefanh]]

Comment on attachment 167195 [details] [diff] [review]
Simple one-liner, removes F9 for mac

Requesting approval for 1.7.5 -- simple fix that just removes an incorrect mac
shortcut from Help.

Comment 3

[Ian Neal]

I know this is just for the help, but because I don't have a Mac I'm not aware
if there are changes needed elsewhere (for example in the View -> Show/Hide
menu). Shouldn't we be looking to find a substitute shortcut rather than
removing it?

Comment 4

[Stefan [:stefanh]]

Attachment: fix for both sidebar and the mailnews Message Pane

Sigh, forgot the mailnews pane.

Comment 5

[Stefan [:stefanh]]

(In reply to comment #4)
> Created an attachment (id=167279)
> fix for both sidebar and the mailnews Message Pane
> 
> Sigh, forgot the mailnews pane.

And of course I mean the Folder pane...

Comment 6

[Stefan [:stefanh]]

(In reply to comment #3)
> I know this is just for the help, but because I don't have a Mac I'm not aware
> if there are changes needed elsewhere (for example in the View -> Show/Hide
> menu). Shouldn't we be looking to find a substitute shortcut rather than
> removing it?

See bug 230023

Comment 7

[[e-mail]]

Comment on attachment 167279 [details] [diff] [review]
fix for both sidebar and the mailnews Message Pane

Nit: <td/> should work, no?

Comment 8

[Stefan [:stefanh]]

Attachment: New version with <td/>

(In reply to comment #7)
> Nit: <td/> should work, no?

Yup, since it is an empty element.

Comment 9

[Stefan [:stefanh]]

Comment on attachment 167357 [details] [diff] [review]
New version with <td/>

Hmm, I seem to create a lot of bugspam...

Comment 10

[[e-mail]]

Comment on attachment 167357 [details] [diff] [review]
New version with <td/>

Yeah, you could have saved yourself a review request for that really small nit.

Comment 11

[Ian Neal]

Comment on attachment 167357 [details] [diff] [review]
New version with <td/>

Checked into trunk.
Checking in shortcuts-mailnews.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/shortcuts-mailnews.xhtm
l
,v  <--  shortcuts-mailnews.xhtml
new revision: 1.12; previous revision: 1.11
done
Checking in shortcuts-navigator.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/shortcuts-navigator.xht
m
l,v  <--  shortcuts-navigator.xhtml
new revision: 1.9; previous revision: 1.8
done

Comment 12

[Stefan [:stefanh]]

--> Fixed.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 167357 [details] [diff] [review]
New version with <td/>

a=asa

Comment 14

[Ian Neal]

Comment on attachment 167357 [details] [diff] [review]
New version with <td/>

Checking in shortcuts-mailnews.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/shortcuts-mailnews.xhtm
l,v  <--  shortcuts-mailnews.xhtml
new revision: 1.4.2.1; previous revision: 1.4
done
Checking in shortcuts-navigator.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/shortcuts-navigator.xht
ml,v  <--  shortcuts-navigator.xhtml
new revision: 1.2.2.1; previous revision: 1.2
done

Comment 15

[Stefan [:stefanh]]

v