272510 - Mac Pinstripe theme doesn't display focus for message grouping

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2004113002-0.9 on Mac OS X 10.3.6. the default Pinstripe theme
doesn't display focus when selecting a group with message grouping.

1. click on any of these columns to sort: Sender (or Recepient), Date, Account,
Label, Subject or Priority.

2. either hit 'g' or select View > Sort by > Grouped by sort. notice in the
thread pane how messages are grouped, with a twisty to the left of the grouping
label (eg, Today, Yesterday, Last Week, etc. if grouped by date sort), which is
expected.

3. click on either the twisty or the grouping label.

expected: the row corresponding to the grouping label should display some sort
of highlighting, indicating that focus is there.

actual results: focus is there (eg, hitting the twisty will expand/collapse it),
but there's no visual indication of where you are. this is particularly
confusing if you didn't hit the twisty exactly, ie, clicking elsewhere on that row.

note that highlighting still displays when clicking (or arrowing w/keys) through
the messages themselves in the thread pane.

Comment 1

[sairuh (rarely reading bugmail)]

Kevin and Scott, would it be feasible to fix this in time for 1.0final?

Comment 2

[Kevin Gerich]

I could get something in tonight. Scott? Too late for 1.0?

Comment 3

[Scott MacGregor]

too late for RC. If we are forced to respin before the final release we could
pick up your fix. 

Comment 4

[Scott MacGregor]

we're definetly respinning for 1.0 Kevin so we can take a low risk fix for this. 

Comment 5

[Kevin Gerich]

I'm sorry, I can't get this together for tonight. My branch build is hosed and I
have to start fresh on my pokey Powerbook. Is the respin happening tonight or
tomorrow morning? FWIW, here's the rules I was looking to add to
mac/mailWindow1.css (this is still untested)

treechildren::-moz-tree-row(dummy, selected, focus)  {
	background-color: #3874d1;
        border-color: #3874d1;
        background-image: none;
	margin: 0px;
}

treechildren::-moz-tree-cell-text(dummy, selected, focus) {
	color: #FFF !important;
}

Comment 6

[Asa Dotzler [:asa]]

Kevin, we've shipped the RC and we'll be looking at feedback the next few days.
There is probably still time to get this in.

Comment 7

[Kevin Gerich]

Landed the fix on the Aviary branch. Landing on the trunk coming shortly. Please
test

Comment 8

[Kevin Gerich]

fixed on branch and trunk

Comment 9

[sairuh (rarely reading bugmail)]

thanks, Kevin, this looks great on 2004120302-0.9.