272551 - File Bookmark dialog should follow work order (checkbox at top)

Status: RESOLVED WONTFIX

(SeaMonkey :: Bookmarks & History, defect)

Description

[Peter Weilbacher]

The dialog reached by Bookmarks->File Bookmark.../Bookmark This Group of Tabs...
does not follow the normal logical work order from top to bottom. While this is
slightly complicated by the multiple methods to call this dialog, I think that
the "Bookmark this group of tabs" checkbox should be placed _above_ the entry
fields at the top of the dialog. Otherwise, I change the "Name" field to say
what I want, decide to bookmark all tabs instead afterwards and then I have to
type the name in again.

Comment 1

[Peter Weilbacher]

Attachment: patch to do the suggested

Comment 2

[Stefan Borggraefe]

How about doing bug 160909 instead? I personally never use this checkbox, but
the two menu items "File Bookmark..." and "Bookmark This Group of Tabs...".

Comment 3

[Peter Weilbacher]

For one, because that bug has been sitting there without anything happening for
last two years. Second, there was one positive remark (from the reporter) about
that idea and several negative ones (if one includes the relevant comments from
bug 160461).
Actually, both ways are OK with me but we have to get this mess cleared up.

Actually, looking at the dialog again, checking the box should also disable the
names in front of the entry fields (Location and Keyword), to make it more clear
that these fields are disabled. This would be the way it is currently handled in
the print dialog.

Additionally, something in the destination folder box should be marked by
default. Otherwise the New Folder button does not work (there is most likely a
bug about that, too). And the new folder button should then be placed above the
destination box (the way it is in the save file picker), because if it is used,
some name for the new folder has to be typed in the box. This currently is above
the button.

Comment 4

[Stefan Borggraefe]

(In reply to comment #3)
> For one, because that bug has been sitting there without anything happening for
> last two years.

I thought I could maybe motivate you to change this. ;-)

> Second, there was one positive remark (from the reporter) about
> that idea and several negative ones (if one includes the relevant comments from
> bug 160461).

The several negative comments were from one person (BenB) and the bug to remove
the checkbox was filed by the owner of Bookmarks. Jeremy M. Dolan was positive
about this idea, too (unless I misunderstand what he wrote back then). I also
think the checkbox is rather useless.

> Additionally, something in the destination folder box should be marked by
> default. Otherwise the New Folder button does not work (there is most likely a
> bug about that, too).

Bug 250783

Comment 5

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 6

[Peter Weilbacher]

OK, this reminder finally convinced me that I should turn my attention rather to
bug 160909 instead of my own idea.