160461 - Remove Bookmark This Page and change wording of File Bookmark...

Status: RESOLVED WONTFIX

(SeaMonkey :: Bookmarks & History, defect)

Description

[Blake Ross]

There are too many ways to add a bookmark currently with fine nuances of
difference.   We should remove the Bookmark This Page menuitem and rename File
Bookmark... to Add Bookmark...

Cc'ing jatin because this affects help content.

Comment 1

[Pierre Chanial]

Yeah!

Comment 2

[Blake Ross]

Attachment: patch

Comment 3

[Pierre Chanial]

Comment on attachment 93662 [details] [diff] [review]
patch

in navigatorOverlay.xul:
+	oncommand="OpenBookmarkURL(event.target, this.database)"">
typo: extra "

2) having addBookmarkAs in contentAreaUtils.js and addGroupmarkAs in
navigator.js is not very consistent. Why did you move it? If there is no
compelling reason, I would prefer you not to move it.

3) addCurPageAsCmd accesskey not updated: should be 'B'

4) While you are cleaning the File Bookmark stuff, you could also fix the
ugliness "Bookmark this Page (L)" in the history context menu when more than
one item are selected. In contentAreaCommands.dtd:
-<!ENTITY addToBookmarksCmd.label      "Bookmark This Page">
-<!ENTITY addToBookmarksCmd.accesskey  "B">
 <!ENTITY bookmarkFrameCmd.accesskey   "f">
+<!ENTITY bookmarkLinksCmd.label       "Bookmark These Links...">
+<!ENTITY bookmarkLinksCmd.accesskey	"L">
and in historyTreeOverlay.xul:
-<data id="multipleBookmarks" label="&addToBookmarksCmd.label;"
accesskey="&addToBookmarksCmd.accesskey;"/>
+<data id="multipleBookmarks" label="&bookmarkLinksCmd.label;"
accesskey="&bookmarkLinksCmd.accesskey;"/>

5) With this patch, the "Set as Default Folder" is worthless. It should be
removed, but it can be done in another bug. (btw, the "Set as internet Search
Folder" is "useless-UI", too)
r=[e-mail]

Comment 4

[Blake Ross]

Attachment: patch - fixes the valid issues mentioned

Comment 5

[Blake Ross]

Comment on attachment 93666 [details] [diff] [review]
patch - fixes the valid issues mentioned

transferring r= and sr=

Comment 6

[Blake Ross]

Comment on attachment 93666 [details] [diff] [review]
patch - fixes the valid issues mentioned

transferring r=pch and sr=ben

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

blake, can you remove "bookmark this group of tabs" as well while you're at it -
it is virtually identical to file bookmark, the only difference being that a
checkbox is checked.

Comment 8

[Pierre Chanial]

*** Bug 158543 has been marked as a duplicate of this bug. ***

Comment 9

[Jeremy M. Dolan]

I know we talked on IRC about removing the Groupmark menu entry too. Perhaps it
turned out Netscape wanted the superfluous UI to better expose this feature? If
that's the case, Cc'ing Asa to see if Mozilla can remove the UI at least.

The proper fix is to better design the Bookmark dialog to make the Groupmark
feature more clear. Not to have two menu items that bring up the same dialog.

Good fix on the "Bookmark These Links" in history.

Comment 10

[Pierre Chanial]

I don't think that the 'Bookmark this group of tabs' menuitem is superfluous.
I'm pretty sure that it will be the access point to groupmarks for the majority
of the users.
I filed bug 160909 to remove the worthless checkbox in the dialog box.

Comment 11

[Ben Bucksch (:BenB)]

I'd vote for keeping the old name "File Bookmark...". I don't think that the
majority of users knows what the elipsis ("...") means, so they will be
confused, if the command "Add Bookmark" now does something else and the command
"File Bookmark..." is gone.
Especially so considering that we don't seem to have a well-thought out concept
that will last for 4 years, so we might end up readding "Add Bookmark" again
later. What do we do then? Rename "Add Bookmark..." back to "File Bookmark..."
again?
Keep in mind: Even 1 change within 2 years for prominent menu items is too much
for users.

Comment 12

[Jeremy M. Dolan]

There's not much to be confused about. You click it. It pops a dialog. Add
bookmark never had any feedback on UNIX/Windows before, now it does. If
anything, it's more clear. And 'Add' is a much more clear word then 'File'. File
sounds closer to Manage then it does Add. That's more confusing.

Comment 13

[Gérard Talbot]

I agree there are right now too many ways to add a bookmark with subtle nuances
of difference. I agree that "Bookmark This Page" menuitem should be removed and
"File Bookmark..." should be renamed "Add Bookmark..."

A rather probant and strong testimonial supporting such requests come from the
recent thread 'NS7 bookmark "secret"(?) revealed??' in
netscape.netscape7.windows on 9/16/2002 9:46 PM. I personally never used
"Bookmark this page" command since, until that thread, I never understood where
the bookmark was stored, saved anyway.  "File bookmark..." though was cleary
indicating where the bookmark was going to be added. 

"(...) it has taken me many hours of precious time to discover where NS7 puts a
bookmark when you click the 'bookmark this page' option."  

I absolutely agree with the summary and the description of this bug. And I am
the first to vote for this bug.

Comment 14

[Stefan Borggraefe]

1. Added dependency to bug 135417 because the proposed changes there are a
subset of the changes considered in this bug.

2. Changing Platform/OS to All/All because all are affected.

3. I think the polish keyword is appropriate here, i.e. see comment #13.

Comment 15

[Peter Weilbacher]

Why was this never checked in? The patch has both r+ and sr+?! And the issue is
still as annoying as it was in 2002...

Comment 16

[[e-mail]]

Note that Bug 186789 had to move Ctrl+D to File Bookmark anyway.

Comment 17

[Peter Weilbacher]

*** Bug 158543 has been marked as a duplicate of this bug. ***

Comment 18

[Peter Weilbacher]

The Ctrl-D change improves matters for keyboard users but for mouse users the
issue is as confusing as ever. Either leave both menu entries and present two
different dialogs (both without checkbox, the one for tab groups missing the
location and keyword entry fields, see bug 160909), or get rid of one menu item
and let the user decide after having opened the dialog (bug 272551).

But why am I commenting at all. Most UI patches for Seamonkey wait for reviews
forever, so I can as well shut up and just fix it in the version on my disk. ;-)

Comment 19

[Jason Bassford]

Carrying over blocking dependency from bug 158543.

Comment 20

[abraendle]

By all means: leave the accellerator Ctrl-D for "Bookmark This Page" (without
Dialog!)

When making lots bookmarks, pressing "ok" for every new bookmark is very annoying.


I don't know who made the change in Mozilla 1.8 alpha 6 (or earlier) but that
has to be changed to the _original behaviour_ (or at least with a
configure-option in about:config) 
(Mozilla 1.8alpha6 has Ctrl-D as File Bookmark and Ctrl-Shift-D as Bookmark this
Page)

Related bugs:

bug 186789

Comment 21

[Wayne Mery (:wsmwk)]

would patch make context menu appear same as Firefox is now (wrt to bookmarks)?