Status

()

Firefox
General
RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: Steffen Wilberg, Assigned: Benjamin Smedberg)

Tracking

Trunk
Points:
---
Bug Flags:
blocking-aviary1.5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
about: is the same as about:blank.
(Reporter)

Comment 1

13 years ago
chrome://global/content/about.xhtml works fine.
But nsAbout.cpp still references chrome://global/locale/about.xhtml:
http://lxr.mozilla.org/seamonkey/source/xpfe/appshell/src/nsAbout.cpp#51

That's because bug 257592 changed that on the branch only.

-> bsmedberg.
Assignee: firefox → bsmedberg

Comment 2

13 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041202
Firefox/1.0+

about: doesn't do anything for me. It doesn't work, but it's not the same as
about:blank either. Typing it simply has no effect (i.e. if a page is loaded, it
won't clear it).
(Reporter)

Comment 3

13 years ago
Comment 0 is wrong (I tried it in a new tab, which already had about:blank
loaded in it).
about: does just nothing.
OS: Linux → All
Hardware: PC → All
Summary: about: is empty/blank → about: is broken
Created attachment 168344 [details] [diff] [review]
Path corrected in nsAbout.cpp

Tested and confirmed that it works.
Attachment #168344 - Flags: review?(bsmedberg)
(Reporter)

Comment 5

13 years ago
Comment on attachment 168344 [details] [diff] [review]
Path corrected in nsAbout.cpp

This breaks about: for Seamonkey:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/global/jar.mn&mark=97#
79

We need to decide where about.xhtml should live: in content, or in locale. Then
we can make it work (again) for both Seamonkey and Firefox.
Attachment #168344 - Flags: review?(bsmedberg) → review-

Updated

13 years ago
Flags: blocking-aviary1.1?
(Assignee)

Comment 6

13 years ago
Created attachment 170488 [details] [diff] [review]
Move about.xhtml to content

There isn't really any localizable content in this file. Let's just move it to
content/. Otherwise, we could possibly use the license.dtd scheme that the
toolkit uses, but that's arcane and I regret doing it that way.
Attachment #168344 - Attachment is obsolete: true
Attachment #170488 - Flags: review?(neil.parkwaycc.co.uk)

Comment 7

13 years ago
Some people like to translate the copyright lines for their language, but I'd
also prefer to have the document in content, and eventually move the
localizeable parts/texts to some .dtd file (like I did for the seamonkey
mailnews start file) - but that can be done later, if needed.

Updated

13 years ago
Attachment #170488 - Flags: review?(neil.parkwaycc.co.uk) → review+

Comment 8

13 years ago
Does the patch need a superreview?

Comment 9

13 years ago
The review for the patch is here. Does it need a superreview or just a volunteer
to check it in?

Updated

13 years ago
Attachment #170488 - Flags: superreview?(alecf)

Comment 10

13 years ago
Comment on attachment 170488 [details] [diff] [review]
Move about.xhtml to content

sr=alecf
Attachment #170488 - Flags: superreview?(alecf) → superreview+
Flags: blocking-aviary1.1? → blocking-aviary1.1+

Comment 11

13 years ago
It would be nice if this was committed it has both a review and superreview.
Anybody going to be able to check it in?
It would be best before we get bitrotten.

/Ieremiou

Comment 12

13 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050315
Firefox/1.0+

verified
(Reporter)

Updated

13 years ago
Keywords: aviary-landing
I have reproduced this bug with Firefox Nightly 1.0 on windows 8.1 64-bit .
Mozilla/5.0 (Windows; U; Windows NT 6.2; en-US; rv:1.8a6) Gecko/20041205 Firefox/1.0+

Verified as fixed with Firefox Aurora 45.0a2 (Build ID: 20151225004009)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

Verified as fixed with Firefox Nightly 46.0a1 (Build ID:20151224030228)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
QA Whiteboard: [bugday-20151223]
You need to log in before you can comment on or make changes to this bug.