272658 - Add user dropdowns to editcomponents.cgi

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[GavinS]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-gb) AppleWebKit/125.5.5 (KHTML, like Gecko) Safari/125.11
Build Identifier: 

editcomponents was not templatized when the user dropdown code was added to bugzilla, but it is 
now, so we can add the user dropdown

Reproducible: Always
Steps to Reproduce:

Comment 1

[Dave Miller [:justdave]]

*** Bug 272659 has been marked as a duplicate of this bug. ***

Comment 2

[Dave Miller [:justdave]]

Getting user matching to work here would be Really Cool, too.

Comment 3

[GavinS]

Attachment: Add the user dropdown to editcomponents

[Grr, blooming safari timeout and resubmit a duplicate bug grr..]

And yes, I'll try and add the user matching as well as this user dropdown at a
later date (there is already a bug for that)

Comment 4

[GavinS]

Comment on attachment 167585 [details] [diff] [review]
Add the user dropdown to editcomponents

Byron: This is extracted from a larger patch on bug#255425 which you looked at
a long time ago, to add the user dropdown to editcomponents. Could you review
sometime please?

Comment 5

[:glob ✱]

Comment on attachment 167585 [details] [diff] [review]
Add the user dropdown to editcomponents

r=glob

Comment 6

[Dave Miller [:justdave]]

holding approval for creation of the 2.20 branch (this will go on the trunk
after we branch)

Comment 7

[Vlad Dascalu]

Targeting bug to 2.20 since the 2.20 feature freeze was canceled.

Comment 8

[Vlad Dascalu]

GavinS: https://bugzilla.mozilla.org/show_bug.cgi?id=255428 got checked in. Do
you still want this in the CVS?

Comment 9

[GavinS]

Attachment: add user dropdown to editcomponents

Updates patch to tip, and adds the 'id=' field to the dropdown and non dropdown
case

Comment 10

[Vlad Dascalu]

Gavin: I was talking about the multiple => 5 thing.

Comment 11

[GavinS]

(In reply to comment #10)
> Gavin: I was talking about the multiple => 5 thing.

I don't think that applies to this editcomponents patch does it? (Or am I
missing something?)

Comment 12

[Vlad Dascalu]

True, you're right, sorry about that.

Comment 13

[:glob ✱]

Comment on attachment 171447 [details] [diff] [review]
add user dropdown to editcomponents

sorry about the delay in looking at this.

checkin for bug 266579 breaks the userselect.html.tmpl change :(

Comment 14

[GavinS]

Attachment: add user dropdown to editcomponents

Updated to tip

Comment 15

[:glob ✱]

Comment on attachment 172036 [details] [diff] [review]
add user dropdown to editcomponents

r=glob

Comment 16

[Shane H. W. Travis]

Checking in template/en/default/admin/components/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/create.h
tml.tmpl,v  <--  create.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/components/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/edit.htm
l.tmpl,v  <--  edit.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/global/userselect.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/userselect.html.tm
pl,v  <--  userselect.html.tmpl
new revision: 1.4; previous revision: 1.3
done