255428 - Allow multiple user selection in CC pull downs

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040618 Firefox/0.9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040618 Firefox/0.9

The new userselect doesn't allow a person to select multiple CC's for a bug. 
Personally, I prefer a free form text field when adding CC's, but at least
a multiple selection should be made available.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Albert Ting]

Attachment: suggested patch

This is a suggested addendum to bug #251669 that only changes
userselect.html.tmpl.
One can then customize the edit/create tmpl files to support multiple
selections
in the CC field

Comment 2

[Frédéric Buclin]

*** Bug 262164 has been marked as a duplicate of this bug. ***

Comment 3

[Marc Schumann [:Wurblzap]]

Comment on attachment 155977 [details] [diff] [review]
suggested patch

There needs to be some kind of "multiple='3'" in bug/edit.html.tmpl.

While I think bug 262164, comment 4, is valid, the corresponding change in
bug/edit-multiple.html.tmpl should imo be done in a separate bug.

Comment 4

[Frédéric Buclin]

*** Bug 273516 has been marked as a duplicate of this bug. ***

Comment 5

[John Beranek]

See bug 277244 for a patch that modifies edit.html.tmpl and create.html.tmpl
too. I can mark that as a duplicate and post my patch here if that's the "right
thing".

Comment 6

[Marc Schumann [:Wurblzap]]

*** Bug 277244 has been marked as a duplicate of this bug. ***

Comment 7

[John Beranek]

Attachment: Patch for Bugzilla, 2.18 branch

Patch for Bugzilla, 2.18 branch.

(Actually run against my local repository, which contains a vendor branch
import of Bugzilla 2.18rc2, but I think it should apply cleanly to the 2.18
branch, and possibly to the tip).

[Originally added to bug 277244 which has since been marked as a duplicate]

Comment 8

[John Beranek]

Oh, it seems I was confused about when userselect.html.tmpl came in, it wasn't
on the 2.18 branch, but rather during development of 2.19, so this is a patch
for the tip.

The patch does apply cleanly to the tip, I just tested it.

Comment 9

[John Beranek]

FYI:

$ patch -p0<~/patch.txt
patching file template/en/default/bug/edit.html.tmpl
Hunk #1 succeeded at 178 (offset 11 lines).
patching file template/en/default/bug/create/create.html.tmpl
Hunk #1 succeeded at 199 (offset -1 lines).
patching file template/en/default/global/userselect.html.tmpl

Comment 10

[John Beranek]

Attachment: Patch for Bugzilla tip 2005/01/06

This patch comes from a cvs diff to mozilla.org CVS tip, so is cleaner than my
previous patch.

Comment 11

[Marc Schumann [:Wurblzap]]

Comment on attachment 170440 [details] [diff] [review]
Patch for Bugzilla tip 2005/01/06

Good patch.

+  [% IF multiple %] multiple size="[% multiple FILTER html %]" [% END %]

You're right in bug 277244, HTML4 indeed allows attributes without values. The
right reference is http://www.bugzilla.org/docs/developer.html#templates, down
at "Web Technologies", where it says code should be as XHTML compatible as
possible, meaning attributes should have values. Please make that
multiple="multiple" (this is what other places in Bugzilla have, too), and
carry forward the review+ flag on your new patch.

Comment 12

[John Beranek]

Attachment: Patch for Bugzilla tip 2005/01/06 attempt 2

Updated patch with suggestion from comment #11

Comment 13

[John Beranek]

Noted the approval? flag, but I'm new to this flag business and
https://bugzilla.mozilla.org/flag-help.html doesn't help. Am I meant to do
something with that flag or not? :)

Comment 14

[Marc Schumann [:Wurblzap]]

(In reply to comment #13)
> Noted the approval? flag, but I'm new to this flag business and
> https://bugzilla.mozilla.org/flag-help.html doesn't help. Am I meant to do
> something with that flag or not? :)

The Bugzilla project leader will now either approve or disapprove of what has
been done here and will set the flag accordingly. Then, either the patch can be
checked in, or we'll need to discuss what shall happen.

Comment 15

[Shankar Unni]

Attachment: Alternate patch for Bugzilla tip

May I submit a slightly modified patch for consideration? The changes from
John's patch (mostly for improved layout) are:

* Added a "loginonly" flag to userselect.html: when set, it only shows the
login name instead of the full name. 
* Set the multiselect size to 3 instead of 5.

The "loginonly" flag makes the multiselect box fit much more cleanly in the
third column of edit.html.tmpl. 

Consider, for instance, how the Reporter column has been folded to make it lay
out nicely: since we can't do the same inside the multi-select box, this makes
the box really wide if you try to display the full name. If showing only the
login names (as in the cc: box), the column is the right size.

And the multiselect size of 5 makes the edit page look rather ugly. 3 is
somewhat better. (Though feel free to change the multiselect size back to 5 for
the create page, if someone feels strongly about it..)

Comment 16

[Shankar Unni]

Attachment: Alternate patch for Bugzilla tip - attempt 2

Oh, darn, forgot to make that a unified diff.

Comment 17

[Marc Schumann [:Wurblzap]]

Comment on attachment 170605 [details] [diff] [review]
Alternate patch for Bugzilla tip - attempt 2

People not having given a full name would show up as empty lines with this
patch. We'd need to fall back on the e-mail address for people not having given
a full name.

Barring this, I think that in a cc box the e-mail addresses are more useful
than the full names because full names are not necessarily unique anyway.

Personally I don't mind very much whether the box size is 3 or 5 lines. If we
agree here, in time before approval+, to change the proposed 5 lines to some
other value, then I'm fine with that. John?

Comment 18

[John Beranek]

I think a height of 3 is too small, I greatly dislike scrolling in very small
windows, you get little feedback about where you are, and I therefore find it
much harder to find the entry/ies I'm looking for.

The height of 5 matches the 5 high multiselect boxes elsewhere in Bugzilla.

Concerning what we show in the multiselect, I agree the:

Name <login>

form may end up too long for some installations. In our installation it's not
bad as our logins are of the form john.beranek. However, I'd be happy with
making it so that the multiselects show just the login/email address. Showing
just the name, as stated above (comment #17), isn't a good solution.

Comment 19

[John Beranek]

Oh, and regarding the milestone, are we saying this is too late for the 2.20
branch? It's a fairly minor enhancement to improve usability greatly.

Comment 20

[Marc Schumann [:Wurblzap]]

This bug didn't change the way how to display the select box contents, so let's
address shortening this to the e-mail addresses in a new bug, if you like.

Let's go with attachment 170445 [details] [diff] [review] and wait for approval. I request blocking2.20 --
maybe it's not too late for 2.20.

Comment 21

[John Beranek]

OK, who's going to enter the new bug, Shankar? :)

Comment 22

[Shankar Unni]

(In reply to comment #17)
> (From update of attachment 170605 [details] [diff] [review] [edit])
> People not having given a full name would show up as empty lines with this
> patch.

Uh, it's the full names that were being removed by the patch - the Email
addresses would always be present.

OK, I can see that 3 might be a bit small for the height.  I guess a better
answer would be to lay out the page somewhat differently, with the first two
columns in one table, and the last one in another table, with both contained in
one top-level table, which would allow things to be laid out more nicely without
ugly gaps.

But for now, ok, I have no problem with the patch being rejected. Thanks for the
review..

(In reply to comment #21)
> OK, who's going to enter the new bug, Shankar? :)

I guess I am :-).

Comment 23

[Marc Schumann [:Wurblzap]]

(In reply to comment #22)
> Uh, it's the full names that were being removed by the patch - the Email
> addresses would always be present.

Ugh. I'm sorry.
You're right. I don't know what I read :(

Let's address shortening and box size in other bugs, and let's keep this at
getting multiple selections in :)

Comment 24

[Vlad Dascalu]

Targeting bug to 2.20 since the 2.20 feature freeze was canceled.

Comment 25

[Vlad Dascalu]

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.49; previous revision: 1.48
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.38; previous revision: 1.37
done
Checking in template/en/default/global/userselect.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/userselect.html.tmpl,v
 <--  userselect.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Comment 26

[Vlad Dascalu]

I've opened bug 278711 and bug 278710 due to this checkin.

Comment 27

[Frédéric Buclin]

*** Bug 285156 has been marked as a duplicate of this bug. ***

Comment 28

[Frédéric Buclin]

*** Bug 286046 has been marked as a duplicate of this bug. ***