272806 - Use templates for page displays

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement)

Description

[alanjstr]

One problem is that we have things hardcoded as themes and plugins, especially
in terms of directory structure.  This means that for
http://update.mozilla.org/themes/ and /extensions/ to work, we have duplicates
of a lot of code.  We should break these pages down so that code such as
showlist.php  lives in a central folder and is merely included as a building
component for /themes/showlist.php.  

themes/showlist.php would contain
{set variables for themes specific}
[header include]
[body include]
[sidebar include]
[footer include]

All includes would go in a central directory.  We could have
[categories_sidebar_include]
[developers_sidebar_include]

This would basically allow us to make page templates.

Comment 1

[Wolf [:wolf]]

Don't reinvent the wheel. Find a nice template engine and use it, but don't
break *anything*. 

Not going to happen anytime soon.

Comment 2

[alanjstr]

http://smarty.php.net/

Comment 3

[alanjstr]

I'll need http://sourceforge.net/projects/smarty-gettext/  too.

Comment 4

[alanjstr]

Attachment: Sample header template

This is a template for the header that swaps in the variables and also allows
localization.

Comment 5

[alanjstr]

Attachment: Wrapper php

This is a wrapper for the header that would call the template.

Also, note that the header template contains all the html headers.  Title and
optional RSS feed link would be passed in, too.

So is this the way to go?

Comment 6

[alanjstr]

Attachment: Template for showlist

The only thing I'm not sure about is a for loop where you just pass in the end.

Comment 7

[alanjstr]

Attachment: Template for showlist

Now covers themes and extensions based on $typename

Comment 8

[alanjstr]

Attachment: inc_header.tpl

Replace tabs with 2 spaces.  Use if block for RSS link.

Comment 9

[alanjstr]

Attachment: inc_header.php

Comment 10

[alanjstr]

Attachment: showlist.tpl

Comment 11

[alanjstr]

Attachment: showlist.php

Still not complete, but big steps forward.

Comment 12

[alanjstr]

Attachment: header and footer template that accepts content and footer

Based on feedback from mconnor

Comment 13

[alanjstr]

Attachment: code used for the search form

Comment 14

[alanjstr]

Attachment: showlist.tpl

mconnor: you get to polish it up.  And do the php.  After that, I'll do the
rest.

Comment 15

[alanjstr]

Attachment: index.tpl - Front Page

Comment 16

[alanjstr]

Fixed with AMO 2.0