273220 - Remove #platform ifdef from mailPrefsOverlay.dtd

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[u60234]

The Options window have different size depending on the platform. Currently,
this is done by shipping different versions of the mailPrefsOverlay.dtd file.

This is not good for localizers since it means that we are forced to have
different translations for each platform.

Could we not have a new entity, macprefWindow.size, similar to what was done to
the Account Manager in bug 259389?

Comment 1

[Vidar Haarr (not reading bugmail)]

Is this fixed now?
<http://lxr.mozilla.org/seamonkey/source/mail/locales/en-US/chrome/messenger/mailPrefsOverlay.dtd>

Comment 2

[u60234]

No, the mailPrefsOverlay.dtd file that ships with the Mac version is still
different from the one in Windows and Linux.

Having a different size of the pref window for Mac and non-Mac is highly
preferable for other locales also, but the current way means that we are forced
to keep two versions of mailPrefsOverlay.dtd.

Comment 3

[Robert Kaiser]

This means major breakage for any producing of .xpi language packs.
If we need different values on different platforms, that should reside inside
-platform/ so it's registered platform-specifically, residing in different files.

Even without language switching panels in aviary, we shouldn't break locale packs.

Additionally, it breaks L10n tools as they don't deal with preprocessed stuff in
L10n files, as they care to produce stuff that works in an .xpi package as well,
and preprocessing doesn't.

Comment 4

[Pavel Franc - Mozilla.cz]

mailPrefsOverlay.dtd is IMHO used only in mailPrefsOverlay.xul
(see http://lxr.mozilla.org/seamonkey/search?string=mailPrefsOverlay.dtd)
that is no longer packed into thunderbird chrome.
(see http://lxr.mozilla.org/seamonkey/source/mailnews/jar.mn)

So, it looks like an orphan that could be removed. 

Comment 5

[Scott MacGregor]

clearing nomination for a bug that's already in our approved 1.1 milestone bucket.

Comment 6

[Scott MacGregor]

this is a dead file that just needs cvs removed. It is not used anymore so it
can't be blocking a release. Taking so I can remove the file