Closed Bug 273220 Opened 21 years ago Closed 21 years ago

Remove #platform ifdef from mailPrefsOverlay.dtd

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird1.1

People

(Reporter: u60234, Assigned: mscott)

References

(
URL
)

Details

(Keywords: l12y)

The Options window have different size depending on the platform. Currently, this is done by shipping different versions of the mailPrefsOverlay.dtd file. This is not good for localizers since it means that we are forced to have different translations for each platform. Could we not have a new entity, macprefWindow.size, similar to what was done to the Account Manager in bug 259389?
No, the mailPrefsOverlay.dtd file that ships with the Mac version is still different from the one in Windows and Linux. Having a different size of the pref window for Mac and non-Mac is highly preferable for other locales also, but the current way means that we are forced to keep two versions of mailPrefsOverlay.dtd.
URL: http://lxr.mozilla.org/mozilla/source... → http://lxr.mozilla.org/seamonkey/sour...
Assignee: mscott → gandalf
Flags: blocking-aviary1.1?
Target Milestone: --- → Thunderbird1.1
This means major breakage for any producing of .xpi language packs. If we need different values on different platforms, that should reside inside -platform/ so it's registered platform-specifically, residing in different files. Even without language switching panels in aviary, we shouldn't break locale packs. Additionally, it breaks L10n tools as they don't deal with preprocessed stuff in L10n files, as they care to produce stuff that works in an .xpi package as well, and preprocessing doesn't.
Severity: normal → major
mailPrefsOverlay.dtd is IMHO used only in mailPrefsOverlay.xul (see http://lxr.mozilla.org/seamonkey/search?string=mailPrefsOverlay.dtd) that is no longer packed into thunderbird chrome. (see http://lxr.mozilla.org/seamonkey/source/mailnews/jar.mn) So, it looks like an orphan that could be removed.
clearing nomination for a bug that's already in our approved 1.1 milestone bucket.
Flags: blocking-aviary1.1?
this is a dead file that just needs cvs removed. It is not used anymore so it can't be blocking a release. Taking so I can remove the file
Assignee: gandalf → mscott
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.