Closed Bug 273759 Opened 20 years ago Closed 14 years ago

nsAttachmentOpener impl of nsIURIContentListener broken

Categories

(Thunderbird :: Message Compose Window, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: bzbarsky, Assigned: gkw)

Details

Attachments

(1 file, 1 obsolete file)

nsAttachmentOpener, in MsgComposeCommands.js, implements nsIURIContentListener,
but a lot of the methods that should be returning a boolean don't actually
return a value.  This works across XPConnect boundaries for now (undefined is
treated as false), but that's not a good thing to depend on.
QA Contact: message-compose
Assignee: mscott → nobody
Attached patch take one (obsolete) — Splinter Review
Assignee: nobody → gary
Status: NEW → ASSIGNED
Attachment #448039 - Flags: review?(neil)
Comment on attachment 448039 [details] [diff] [review]
take one

Please find a Thunderbird peer.
Attachment #448039 - Flags: review?(neil)
Comment on attachment 448039 [details] [diff] [review]
take one

Whoops - misread the path name..
Attachment #448039 - Flags: review?(bienvenu)
Comment on attachment 448039 [details] [diff] [review]
take one

thx for the patch, Gary. But, onStartURIOpen also looks like a boolean.
Attachment #448039 - Flags: review?(bienvenu) → review-
Attached patch take twoSplinter Review
Attachment #448039 - Attachment is obsolete: true
Attachment #448111 - Flags: review?(bienvenu)
Comment on attachment 448111 [details] [diff] [review]
take two

looks good, thx, Gary.
Attachment #448111 - Flags: review?(bienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/e98480ac67a8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: