273759 - nsAttachmentOpener impl of nsIURIContentListener broken

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Boris Zbarsky [:bzbarsky]]

nsAttachmentOpener, in MsgComposeCommands.js, implements nsIURIContentListener,
but a lot of the methods that should be returning a boolean don't actually
return a value.  This works across XPConnect boundaries for now (undefined is
treated as false), but that's not a good thing to depend on.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: take one

Comment 2

[[e-mail]]

Comment on attachment 448039 [details] [diff] [review]
take one

Please find a Thunderbird peer.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 448039 [details] [diff] [review]
take one

Whoops - misread the path name..

Comment 4

[David :Bienvenu]

Comment on attachment 448039 [details] [diff] [review]
take one

thx for the patch, Gary. But, onStartURIOpen also looks like a boolean.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: take two

Comment 6

[David :Bienvenu]

Comment on attachment 448111 [details] [diff] [review]
take two

looks good, thx, Gary.

Comment 7

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e98480ac67a8