Closed
Bug 273759
Opened 20 years ago
Closed 14 years ago
nsAttachmentOpener impl of nsIURIContentListener broken
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a1
People
(Reporter: bzbarsky, Assigned: gkw)
Details
Attachments
(1 file, 1 obsolete file)
951 bytes,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
nsAttachmentOpener, in MsgComposeCommands.js, implements nsIURIContentListener, but a lot of the methods that should be returning a boolean don't actually return a value. This works across XPConnect boundaries for now (undefined is treated as false), but that's not a good thing to depend on.
Updated•17 years ago
|
QA Contact: message-compose
Updated•16 years ago
|
Assignee: mscott → nobody
Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment on attachment 448039 [details] [diff] [review] take one Please find a Thunderbird peer.
Attachment #448039 -
Flags: review?(neil)
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 448039 [details] [diff] [review] take one Whoops - misread the path name..
Attachment #448039 -
Flags: review?(bienvenu)
Comment 4•14 years ago
|
||
Comment on attachment 448039 [details] [diff] [review] take one thx for the patch, Gary. But, onStartURIOpen also looks like a boolean.
Attachment #448039 -
Flags: review?(bienvenu) → review-
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #448039 -
Attachment is obsolete: true
Attachment #448111 -
Flags: review?(bienvenu)
Comment 6•14 years ago
|
||
Comment on attachment 448111 [details] [diff] [review] take two looks good, thx, Gary.
Attachment #448111 -
Flags: review?(bienvenu) → review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 7•14 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/e98480ac67a8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•