273857 - Text in table not centered, where table has width="95%" and is inside an align="center" div

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Ali Ebrahim]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041208
Firefox/1.0+

Text inside a table is left aligned, not centered where <table width="95%"> and
is inside a <div align="center">.

IE6 and Opera 7.54 both agree and place the text in the center.

When the align="center" is removed, Gecko/Opera/IE agree text should be left
aligned. When the width="95%" is removed, they all agree text should be centered.

Will attach testcase shortly.

Comment 1

[Ali Ebrahim]

Attachment: Testcase per comment 0

Attaching testcase, as described in comment 0.

Comment 2

[Bernd]

Attachment: more visible testcase

Comment 3

[Bernd]

Attachment: div div

Comment 4

[Bernd]

Attachment: div div

Comment 5

[Bernd]

http://lxr.mozilla.org/seamonkey/source/content/base/src/nsStyleContext.cpp#367
is responsible for this.

patches, thoughts why have this, what IE does under different circumstances are
wellcome

 // Correct tables.
368   const nsStyleDisplay* disp = GetStyleDisplay();
369   if (disp->mDisplay == NS_STYLE_DISPLAY_TABLE) {
370     // -moz-center and -moz-right are used for HTML's alignment
371     // This is covering the <div align="right"><table>...</table></div> case.
372     // In this case, we don't want to inherit the text alignment into the table.
373     const nsStyleText* text = GetStyleText();
374     
375     if (text->mTextAlign == NS_STYLE_TEXT_ALIGN_MOZ_CENTER ||
376         text->mTextAlign == NS_STYLE_TEXT_ALIGN_MOZ_RIGHT)
377     {
378       nsStyleText* uniqueText =
(nsStyleText*)GetUniqueStyleData(eStyleStruct_Text);
379       uniqueText->mTextAlign = NS_STYLE_TEXT_ALIGN_DEFAULT;
380     }
381   }

Comment 6

[Mats Palmgren (inactive)]

Attachment: "more visible testcase" in Quirks mode

Comment 7

[Mats Palmgren (inactive)]

See bug 40038 comment 7.

Comment 8

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Both IE6/win32 and Opera7/linux left-aligns in Quirks mode and centers in
Standars mode. I think this is what was intended originally in bug 40038.
This patch makes us do the same.  (FWIW, NS4 left-aligns).

Comment 9

[Mats Palmgren (inactive)]

... and for the DIV/DIV case, IE6, Opera and Mozilla agrees on center aligned
text in both Quirks and Standards mode so that looks OK.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

align="left" and align="right" should continue to affect tables even in
standards mode

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 168362 [details] [diff] [review]
Patch rev. 1

A little more context in the diff would have been nice.

This is not what was intended originally, but now that WinIE6 does this in
standards mode we may as well follow.

Comment 12

[Mats Palmgren (inactive)]

Attachment: align=right, Standards mode

Comment 13

[Mats Palmgren (inactive)]

Attachment: align=right, Quirks mode

Comment 14

[Mats Palmgren (inactive)]

Attachment: align=left, Standards mode

Comment 15

[Mats Palmgren (inactive)]

Attachment: align=left, Quirks mode

Comment 16

[Mats Palmgren (inactive)]

With the patch all three browsers are compatible except for one case;
Opera centers the text for "align=left, Standards mode", where IE6/Mozilla
left aligns it.

Comment 17

[Bernd]

Attachment: standard rendering more cases

Comment 18

[Bernd]

Attachment: quirks mode more cases

Comment 19

[Bernd]

I dont believe that the patch is correct, if one places a break point at
http://lxr.mozilla.org/seamonkey/source/layout/style/nsStyleContext.cpp#378 and
loads attachment 168465 [details], we never hit the break point. This is understandable if
one looks at http://lxr.mozilla.org/seamonkey/source/layout/style/quirk.css#97.
So this patch is equivivalent to a removal. Why do we not remove the fixup? Or
is there a scenario when we need this in quirks mode?

Comment 20

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Yes, you're right, I think we should remove this block and let quirk.css take
care of the quirk. This will also enable authors to override the quirk by
specifying 'text-align:inherit' (which the 1st patch doesn't allow).

Comment 21

[Mats Palmgren (inactive)]

Checked in 2004-12-23 14:02 PDT

-> FIXED

Comment 22

[Ali Ebrahim]

Thanks Mats, I verify that this patch also fixed the rendering on the page on
which I was originally having the issue. :)

Comment 23

[Ali Ebrahim]

Hmm, the Safari that ships with OSX 10.3.7 renders this differently from
Gecko/IE/Opera. It left aligns the 'foo' in the testcases. Weird, that. Are we
all sure that we've arrived at the right resolution here?

Comment 24

[Ali Ebrahim]

Attachment: Safari 1.2.4 (v125.12) rendering of attachment 168464

This is a screenshot of the rendering of attachment 168464 [details] by:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/125.5.5 (KHTML, like
Gecko) Safari/125.12

(Uploading at request of bernd).

Comment 25

[Ali Ebrahim]

Attachment: Safari 1.2.4 (v125.12) rendering of attachment 168465

This is a screenshot of the rendering of attachment 168465 [details] by:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/125.5.5 (KHTML, like
Gecko) Safari/125.12

(Uploading at request of bernd).

Comment 26

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 300374 suggests this patch was wrong.  I agree.  I don't think the change
makes much sense, and I'm really not sure why I granted superreview except for
seeing the claim that it matches WinIE6 in standards mode.

Comment 27

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sorry, bug 300734 (incorrect number in previous comment).