275227 - output element with label shows output before label

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Once I apply bug 269023 so that labels work, can see right away that
xforms:output elements' values will appear BEFORE their xforms:label's value. 
Testcase coming.

Comment 1

[aaronr]

Attachment: testcase

Testcase that shows the problem.

Comment 2

[Doron Rosenberg (IBM)]

Attachment: quick fix

Still figuring out how this works, but this seems to do the trick.  However,
selecting all the text is impossible now.

Comment 3

[aaronr]

Comment on attachment 170601 [details] [diff] [review]
quick fix

brian, I put you to sr since it is based off of how you handle label with input
element.  Thanks.

Comment 4

[aaronr]

Comment on attachment 170601 [details] [diff] [review]
quick fix

Sorry, found bugs when I tried your patch.  Will post testcase.

Comment 5

[aaronr]

Attachment: testcase that shows bad layout behavior

built on the XFORMS_20050106_BRANCH with this patch.  With this testcase, what
the user SHOULD see is two lines; a label:value laid out next to another
label:value with a label:value on the line below.

What the user will see is a label:value with another label:value way off to the
right, outside the body.  Then on the next line is a label with its value on a
third line.

Comment 6

[Darin Fisher]

the most likely problem is the div.  that should probably be a span instead. 
you cannot have a block element as a child of an inline element.

Comment 7

[Doron Rosenberg (IBM)]

(In reply to comment #6)
> the most likely problem is the div.  that should probably be a span instead. 
> you cannot have a block element as a child of an inline element.

Hmm, I guess I could have a span and 2 child textnodes.  That might work.

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 170601 [details] [diff] [review]
quick fix

minusing per aaron's comments.

Comment 9

[Doron Rosenberg (IBM)]

Attachment: use a label rather than a div.

Comment 10

[Doron Rosenberg (IBM)]

Attachment: use spans rather than label

Comment 11

[Doron Rosenberg (IBM)]

I choose to use html:span over html:label because I don't think we need the
extra functionality that html:label brings with it.

Comment 12

[Doron Rosenberg (IBM)]

Attachment: add description of why not using a html:label per aaron

Comment 13

[aaronr]

Comment on attachment 170841 [details] [diff] [review]
add description of why not using a html:label per aaron

r=aaronr

Comment 14

[Allan Beaufour]

Checked in through bug 278896.

Comment 15

[aaronr]

Comment on attachment 170838 [details] [diff] [review]
use spans rather than label

turning off so it doesn't show in my review queue