Closed Bug 275753 Opened 17 years ago Closed 14 years ago

about dialog should not be modal

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 beta4

People

(Reporter: jwz, Assigned: ehsan.akhgari)

References

()

Details

Attachments

(1 file)

You can't type into other Firefox windows when the About Mozilla Firefox dialog
is up.  Among other things, this means that I can't:

  - bring up the about dialog
  - select the version string text
  - paste it here in bugzilla

Modal dialogs bad.  Baaad.


Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0
Related (in the "I'm not in the mood to dup either one of you" sense): bug 250077
Assignee: firefox → nobody
QA Contact: bugzilla → menus
Is there any special reason why this dialog has to be modal?  Bug 267227 moved openAboutDialog() from browser.js to utilitOverlay.js (see the original version in browser.js: <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/browser.js&rev=1.402#2758>).  I was able to track the change to here: <http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=/mozilla/browser/base/content&command=DIFF_FRAMESET&file=browser.js&rev2=1.34&rev1=1.33>.  The changelog for rev 34 is: "Add note about a workaround." (<http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/browser/base/content/browser.js&rev=1.34>) which doesn't help a lot...

Does anybody know why this dialog should not be modal?  I have a simple patch which I will attach shortly which makes this non-modal, and I can't seem to find any problem with a non-modal dialog.  It only simplifies the use cases such as that in comment 0.
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
Attached patch Patch (v1)Splinter Review
Trivial patch to make the about dialog non-modal.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #296379 - Flags: review?(gavin.sharp)
Target Milestone: --- → Firefox 3 M11
Comment on attachment 296379 [details] [diff] [review]
Patch (v1)

Better to get ui-review on these kinds of changes before asking for code review.
Attachment #296379 - Flags: review?(gavin.sharp) → ui-review?(beltzner)
After a lot of looking, I finally found a single non-modal About on Windows - the supremely non-native Safari.

On Linux, which was what jwz cared about and filed this bug on (and which should thus prevent a wontfix when someone decides we don't want to follow Safari for Windows behavior), the correct behavior would be more like the Help window is on Windows - not modal, but always raised.
Attachment #296379 - Flags: ui-review?(beltzner) → ui-review+
Attachment #296379 - Flags: review?(gavin.sharp)
Gavin: will you have some cycles to review this patch?
Attachment #296379 - Flags: review?(gavin.sharp) → review+
Target Milestone: Firefox 3 beta3 → Firefox 3 beta4
Attachment #296379 - Flags: approval1.9?
Attachment #296379 - Flags: approval1.9? → approval1.9+
Checking in browser/base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.61; previous revision: 1.60
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Blocks: 417733
verified fixed using Build identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008021904 Minefield/3.0b4pre. Also verified on Mac using the nightly.
Status: RESOLVED → VERIFIED
No longer blocks: 417733
Depends on: 417733
You need to log in before you can comment on or make changes to this bug.