Closed Bug 277625 Opened 21 years ago Closed 21 years ago

Context menu Copy Email Address not unescaping

Categories

(SeaMonkey :: UI Design, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: mconnor)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

Build id: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050108 bug 160055 fixed the context menu Copy Email Address to unescape %40 to @, but something has regressed it. My limited supply of regression testing builds says that in Firefox's branch builds (with the same code copied over in bug 215993), it regressed sometime between 20041010 and 20041017, where to my uneducated eye bug 263462 seems most likely. STR: 1. Open attachment 93238 [details] 2. Right-click, Copy Email Address 3. Paste into text editor, observe %40 rather than @
Attached patch patchSplinter Review
Assignee: guifeatures → mconnor
Status: NEW → ASSIGNED
Attachment #170767 - Flags: superreview?(bzbarsky)
Attachment #170767 - Flags: review?(bzbarsky)
Comment on attachment 170767 [details] [diff] [review] patch r+sr=bzbarsky, if you remove the crud about "ASCII" from that comment. Could we please take this for 1.8a6? This is a pretty annoying regression and a safe fix.
Attachment #170767 - Flags: superreview?(bzbarsky)
Attachment #170767 - Flags: superreview+
Attachment #170767 - Flags: review?(bzbarsky)
Attachment #170767 - Flags: review+
Attachment #170767 - Flags: approval1.8a6?
Comment on attachment 170767 [details] [diff] [review] patch a=asa for checkin to 1.8a6.
Attachment #170767 - Flags: approval1.8a6? → approval1.8a6+
Checking in xpfe/communicator/resources/content/nsContextMenu.js; /cvsroot/mozilla/xpfe/communicator/resources/content/nsContextMenu.js,v <-- nsContextMenu.js new revision: 1.97; previous revision: 1.96 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
http://lxr.mozilla.org/seamonkey/source/mail/base/content/mailContextMenus.js#575 may need the same fix (I found you had fixed browser.js).
*** Bug 273368 has been marked as a duplicate of this bug. ***
(In reply to comment #5) > mailContextMenus.js#575 may need the same fix Indeed it did, among others: fixed in bug 397443.
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: