Closed Bug 277928 Opened 20 years ago Closed 20 years ago

quitting while downloading a file causes crash

Categories

(Camino Graveyard :: Downloading, defect)

Product:
Camino Graveyard
Component:
Downloading
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Camino0.9

People

(Reporter: David, Assigned: mikepinkerton)

References

Details

(Keywords: crash, fixed1.7.6, verified1.7.6)

Attachments

(1 file)

fix v1.0
2.21 KB, patch
sfraser_bugs
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
If you are downloading a file, and quits the program, it asks from the download
window if you really want to quit, or cancel. But if the file finishes before
you press quit/cancel, and you have auto-close for the download window enabled,
Camino gets unresponsive and you have to force-quit it.
I can confrim. Josh this is probably something you overlooked when making the
auto close pre.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
oops
Target Milestone: --- → Camino0.9
dl manager autoclose does not have to be enabled. From looking at a stack trace,
this does not appear to be a problem with the dl manager code per se. Its
another issue of releaseing gecko services in the wrong order.

Summary updated, severity upped, reassigned to pinkerton.
Assignee: joshmoz → pinkerton
Summary: If quitting while downloading a file and it ask for confirmation, and auto-close is enabled, Camino dies → quitting while downloading a file causes crash
when did this regress? it used to work just fine.
I thought the summary for this bug sounded familiar and found bug 244676. 
There's no crash report for this one, so no way for me to guess more accurately
if they are dupes.  (If they are dupes, that would mean regression happened by 0.8b)
*** Bug 244676 has been marked as a duplicate of this bug. ***
Attached patch fix v1.0 — — Splinter Review 

        Attachment #172013 -
        Flags: superreview?(pinkerton)

        Attachment #172013 -
        Flags: review?(sfraser_bugs)

        Attachment #172013 -
        Flags: review?(sfraser_bugs) → review+

    
    

    
  
Comment on attachment 172013 [details] [diff] [review]
fix v1.0

sr=pink

        Attachment #172013 -
        Flags: superreview?(pinkerton) → superreview+
Blocks: 279168

    
    

    
  
landed on trunk
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
  
Severity: major → critical
Keywords: crash

    
    

    
  
landed on branch.

    
    

    
  
landed on branch.
Keywords: fixed1.7.6

    
    

    
  
verified fixed using these camino builds on mac os x 10.3.8:

2005031008-trunk
20050212-0.8.3 branch

changing "fixed1.7.6" to "verified1.7.6" since I tested using a camino branch build.
Status: RESOLVED → VERIFIED
Keywords: fixed1.7.6 → verified1.7.6

    
    

    
  
mistakenly removed fixed1.7.6 --pardon the bugspam. set your filter/quicksearch
to "ZippidityDooDahHey" to catch these for easy removal/etc/
Keywords: fixed1.7.6

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: