Closed
Bug 278377
Opened 20 years ago
Closed 19 years ago
Add "Window" and "Help" menus to "View Source" and "DOM Inspector" windows
Categories
(Firefox :: Menus, defect, P2)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox1.5
People
(Reporter: sugar.waffle, Assigned: asaf)
References
Details
Attachments
(4 files, 1 obsolete file)
33.17 KB,
image/png
|
Details | |
18.40 KB,
image/png
|
Details | |
10.07 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
5.41 KB,
patch
|
mconnor
:
review+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
There is no item of Window and Help in the menu when "View Page Source" and "DOM Inspactor" are executed. I think that there should be a standard menu item. Reproducible: Always Mac OS X 10.3.7 Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.8a6) Gecko/20050112 Firefox/1.0+
Comment 3•20 years ago
|
||
*** This bug has been marked as a duplicate of 267227 ***
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Summary: There is no item of "Window" and "Help" in the menu of "View Page source" and "DOM Inspactor". → There is no item of "Window" and "Help" in the menu of "View Page source" and "DOM Inspactor".
Assignee | ||
Comment 4•20 years ago
|
||
not a dupe, only dependent
Assignee | ||
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•19 years ago
|
Assignee: firefox → bugs.mano
OS: MacOS X → All
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → Firefox1.1
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•19 years ago
|
||
Also, i just realized: the "Promote Firefox" menuitem doesn't work in non-browser windows, I fixed that as well (by moving getUILink to utility overlay and moving the reginon string bundle to baseMenuOverlay).
Attachment #178680 -
Flags: review?(mconnor)
Comment 6•19 years ago
|
||
Comment on attachment 178680 [details] [diff] [review] Fix DOMi >=================================================================== >RCS file: /cvsroot/mozilla/browser/extensions/inspector/content/inspector.xul,v >retrieving revision 1.2 >diff -u -p -8 -r1.2 inspector.xul >--- browser/extensions/inspector/content/inspector.xul 22 May 2004 20:59:00 -0000 1.2 >+++ browser/extensions/inspector/content/inspector.xul 26 Mar 2005 19:45:19 -0000 >@@ -69,16 +71,19 @@ > <command id="cmd_quit"/> > </commandset> > > <keyset id="tasksKeys"> > <key id="key_closeInspector" key="&closeCmd.key;" command="cmdClose" > modifiers="accel"/> > </keyset> > >+ <commandset id="baseMenuCommandSet"/> >+ <keyset id="baseMenuKeyset"/> >+ nit: move the commandset to below the other commandset. r=me
Attachment #178680 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 7•19 years ago
|
||
leavin open for View Source. Checking in base/content/baseMenuOverlay.xul; /cvsroot/mozilla/browser/base/content/baseMenuOverlay.xul,v <-- baseMenuOverlay.xul new revision: 1.2; previous revision: 1.1 done Checking in base/content/browser-sets.inc; /cvsroot/mozilla/browser/base/content/browser-sets.inc,v <-- browser-sets.inc new revision: 1.43; previous revision: 1.42 done Checking in base/content/browser.js; /cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js new revision: 1.405; previous revision: 1.404 done Checking in base/content/utilityOverlay.js; /cvsroot/mozilla/browser/base/content/utilityOverlay.js,v <-- utilityOverlay.js new revision: 1.18; previous revision: 1.17 done Checking in components/bookmarks/content/bookmarksManager.xul; /cvsroot/mozilla/browser/components/bookmarks/content/bookmarksManager.xul,v <-- bookmarksManager.xul new revision: 1.27; previous revision: 1.26 done Checking in extensions/inspector/jar.mn; /cvsroot/mozilla/browser/extensions/inspector/jar.mn,v <-- jar.mn new revision: 1.7; previous revision: 1.6 done Checking in extensions/inspector/content/inspector.xul; /cvsroot/mozilla/browser/extensions/inspector/content/inspector.xul,v <-- inspector.xul new revision: 1.3; previous revision: 1.2 done Checking in extensions/inspector/content/toolboxOverlay.xul; /cvsroot/mozilla/browser/extensions/inspector/content/toolboxOverlay.xul,v <-- toolboxOverlay.xul new revision: 1.3; previous revision: 1.2 done
Whiteboard: DOMi is fixed.
Assignee | ||
Updated•19 years ago
|
Summary: There is no item of "Window" and "Help" in the menu of "View Page source" and "DOM Inspactor". → Add "Window" and "Help" menus to "View Source" and "DOM Inspactor" windows
Updated•19 years ago
|
Summary: Add "Window" and "Help" menus to "View Source" and "DOM Inspactor" windows → Add "Window" and "Help" menus to "View Source" and "DOM Inspector" windows
Assignee | ||
Comment 8•19 years ago
|
||
Attachment #189484 -
Flags: review?(mconnor)
Assignee | ||
Updated•19 years ago
|
Attachment #189484 -
Attachment is obsolete: true
Attachment #189484 -
Flags: review?(mconnor) → review-
Assignee | ||
Comment 9•19 years ago
|
||
Attachment #189485 -
Flags: review?(mconnor)
Assignee | ||
Updated•19 years ago
|
Flags: blocking1.8b4?
Updated•19 years ago
|
Attachment #189485 -
Flags: review?(mconnor) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #189485 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #189485 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 10•19 years ago
|
||
Checking in browser/base/jar.mn; /cvsroot/mozilla/browser/base/jar.mn,v <-- jar.mn new revision: 1.91; previous revision: 1.90 done Checking in toolkit/components/viewsource/content/viewPartialSource.xul; /cvsroot/mozilla/toolkit/components/viewsource/content/viewPartialSource.xul,v <-- viewPartialSource.xul new revision: 1.20; previous revision: 1.19 done Checking in toolkit/components/viewsource/content/viewSource.xul; /cvsroot/mozilla/toolkit/components/viewsource/content/viewSource.xul,v <-- viewSource.xul new revision: 1.24; previous revision: 1.23 done Checking in viewSourceOverlay.xul; /cvsroot/mozilla/browser/base/content/viewSourceOverlay.xul,v <-- viewSourceOverlay.xul new revision: 1.6; previous revision: 1.5 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago → 19 years ago
Flags: blocking1.8b4?
Resolution: --- → FIXED
Whiteboard: DOMi is fixed.
Updated•18 years ago
|
QA Contact: bugzilla → menus
You need to log in
before you can comment on or make changes to this bug.
Description
•