278433 - setvalue element doesn't use @value as context

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

According to the XForms Errata:
http://www.w3.org/MarkUp/Forms/Group/errata-10.html#2.2.3.E7:%20Evaluation%20Context%20for%20%3Csetvalue%3E%20(section%2010.1.9)|outline

The expression evaluated in the @value of xforms:setvalue is supposed to have
the context node of the node that setvalue is bound to.  We currently do not
follow this behavior.

I will attach testcase that shows this off.

Comment 1

[aaronr]

Attachment: testcase that exhibits the problem

testcase that exhibits the problem.  When you click on the pushbutton, the
value should be changed as noted in the testcase.

Comment 2

[aaronr]

Attachment: proposed fix

Note: I changed around HandleAction to be more efficient (I hope) now that we
need to know single node binding before we figure out the value to set when
there is a non-empty value attribute.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 171289 [details] [diff] [review]
proposed fix

>   nsAutoString value;
...
>+  nsAutoString valueattr;
>+  mElement->GetAttribute(NS_LITERAL_STRING("value"), valueattr);

Could you move these lines to be just before if(!valueattr.IsEmpty())

Comment 4

[aaronr]

Attachment: fix with smaug's comments

same patch as before, just accounted for Smaug's comment.

Comment 5

[Darin Fisher]

Comment on attachment 171298 [details] [diff] [review]
fix with smaug's comments

"valueAttr" over "valueattr" is generally preferred in mozilla code.

Comment 6

[Darin Fisher]

fixed on xforms branch

leaving open for merge with trunk

Comment 7

[Allan Beaufour]

Checked in via bug 278896.