278663 - cite attribute of blockquote misses colon in URL

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Reply to mail using HTML editor, with quote, send as HTML
2. Look at source code of sent msg

Actual result:
<blockquote cite="[e-mail]"
 type="cite">

Expected result:
<blockquote cite="mid:[e-mail]"
 type="cite">

Comment 1

[Ben Bucksch (:BenB)]

hm, I have no idea where that even comes from. I thought it's from mimetpla.cpp,
but I can't see any cite attribute being added there (only type="cite", which is
something else).

Comment 2

[Akkana Peck]

nsHTMLEditor::InsertAsCitedQuotation inserts the cite string
(cite="blahblah"):http://lxr.mozilla.org/seamonkey/source/editor/libeditor/html/nsHTMLDataTransfer.cpp#2342
But the cite string (the thing with the mid:) is passed in to that routine.
Looks like it's mCiteReference in nsMsgCompose::ConvertAndLoadComposeWindow:
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#509

The mid: may come from here:
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#1795
or it might already be in myGetter.  I don't know that code, but that's probably
the place to start looking.

Comment 3

[Magnus Melin [:mkmelin]]

*** Bug 185562 has been marked as a duplicate of this bug. ***

Comment 4

[Magnus Melin [:mkmelin]]

Yeah, originally it was "mid:", but it seems the colon accidentially got removed in bug 109179. 

I have a patch to make us follow rfc 2111 again.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix: add back the colon for mid:

Add back the colon in the ULR, so we get mid:messageid, not midmessageid in blockquote href.

Comment 6

[David :Bienvenu]

Comment on attachment 241344 [details] [diff] [review]
proposed fix: add back the colon for mid:

thx

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/compose/src/nsMsgCompose.cpp 	1.495

Comment 8

[Mike Cowperthwaite]

Comment on attachment 241344 [details] [diff] [review]
proposed fix: add back the colon for mid:

This is a small, simple, and useful patch.  I'll ask for 1.8.1, and if denied, I'll ask for 1.8.1.1.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 241344 [details] [diff] [review]
proposed fix: add back the colon for mid:

a=beltzner on behalf of drivers for the 1.8.1 branch (mailnews only)

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/compose/src/nsMsgCompose.cpp 	1.460.2.24

Comment 11

[Mike Cowperthwaite]

V fixed with TB 2b1-1018.