Closed Bug 278663 Opened 16 years ago Closed 14 years ago
cite attribute of blockquote misses colon in URL
Reproduction: 1. Reply to mail using HTML editor, with quote, send as HTML 2. Look at source code of sent msg Actual result: <blockquote cite="email@example.com" type="cite"> Expected result: <blockquote cite="mid:firstname.lastname@example.org" type="cite">
hm, I have no idea where that even comes from. I thought it's from mimetpla.cpp, but I can't see any cite attribute being added there (only type="cite", which is something else).
nsHTMLEditor::InsertAsCitedQuotation inserts the cite string (cite="blahblah"):http://lxr.mozilla.org/seamonkey/source/editor/libeditor/html/nsHTMLDataTransfer.cpp#2342 But the cite string (the thing with the mid:) is passed in to that routine. Looks like it's mCiteReference in nsMsgCompose::ConvertAndLoadComposeWindow: http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#509 The mid: may come from here: http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#1795 or it might already be in myGetter. I don't know that code, but that's probably the place to start looking.
*** Bug 185562 has been marked as a duplicate of this bug. ***
Yeah, originally it was "mid:", but it seems the colon accidentially got removed in bug 109179. I have a patch to make us follow rfc 2111 again.
Add back the colon in the ULR, so we get mid:messageid, not midmessageid in blockquote href.
Comment on attachment 241344 [details] [diff] [review] proposed fix: add back the colon for mid: thx
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 241344 [details] [diff] [review] proposed fix: add back the colon for mid: This is a small, simple, and useful patch. I'll ask for 1.8.1, and if denied, I'll ask for 220.127.116.11.
Attachment #241344 - Flags: approval1.8.1?
Comment on attachment 241344 [details] [diff] [review] proposed fix: add back the colon for mid: a=beltzner on behalf of drivers for the 1.8.1 branch (mailnews only)
Attachment #241344 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: mozilla1.9alpha → mozilla1.8.1
V fixed with TB 2b1-1018.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.