278925 - AMO expects the site to be on port 80

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[(not currently active) Ted Mielczarek]

Update breaks on developer login if the site isn't running on port 80.  That sucks.

Comment 1

[alanjstr]

This is probably a legacy from when we only used SSL for login.

There's two lines that need to be changed.

http://lxr.mozilla.org/mozilla/source/webtools/update/developers/login.php#40

Do we need to redirect to the full URL explicitly?  If not, then just send to 
"/" . $return_path

If so, then we need a lot more logic to deal with things not on port 80 and https

Comment 2

[alanjstr]

Same problem with developers/logout.php and developers/index.php

Comment 3

[Wolf [:wolf]]

it breaks because of code to handle proxy. :-)

Comment 4

[(not currently active) Ted Mielczarek]

We might be able to just stick ":$_SERVER[SERVER_PORT]" in there.

Comment 5

[alanjstr]

What about http vs https?  That's not implicit by port 443.

Comment 6

[Colin Ogilvie [:cso]]

Two options I can see:

1) Make $sitehostname take the full URL path:
     $sitehostname = "https://mytestsite.com:444/";

or 
2) A function looseley based around the following would probably work, where you
keep $sitehostname as

    $sitehostname = "mytestsite.com";

<?
if (isset($_SERVER['HTTPS'] && strtolower($_SERVER['HTTPS']) == 'on'))
{
        $server = 'https://';
}
else
{
        $server = 'http://';
}

$server .= $sitehostname;

if ($_SERVER['SERVER_PORT'] != 80)
{
        $server .= ':' . $_SERVER['SERVER_PORT'] .'/';
}
?>


I suspect the "proxy-safe" version is 1 as you may want to direct users to

    https://www.mysitedomain.com:444/extensions/

where that is squid which forwards to

    http://internaldomain/extensions/

and I'm not entirely sure how the Apache Variables would handle that...

Comment 7

[Michael Morgan [:morgamic]]

Mass change - bugs to be read / (re)confirmed.

Comment 8

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 9

[Cameron]

Bugspam makes us be-come druggies
Fa-la-la-la-la, la-la-la-la
Get morgamic some more coffee
Fa-la-la-la-la, la-la-la-la

Updating all the bugs which have "Update" or "UMO" in them.

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Fixed in the remora trunk, which is where we should all be!