AMO expects the site to be on port 80

RESOLVED FIXED in 2.0

Status

addons.mozilla.org Graveyard
Public Pages
P5
normal
RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: ted, Unassigned)

Tracking

unspecified

Details

(Reporter)

Description

13 years ago
Update breaks on developer login if the site isn't running on port 80.  That sucks.

Comment 1

13 years ago
This is probably a legacy from when we only used SSL for login.

There's two lines that need to be changed.

http://lxr.mozilla.org/mozilla/source/webtools/update/developers/login.php#40

Do we need to redirect to the full URL explicitly?  If not, then just send to 
"/" . $return_path

If so, then we need a lot more logic to deal with things not on port 80 and https

Comment 2

13 years ago
Same problem with developers/logout.php and developers/index.php

Comment 3

13 years ago
it breaks because of code to handle proxy. :-)
(Reporter)

Comment 4

13 years ago
We might be able to just stick ":$_SERVER[SERVER_PORT]" in there.

Comment 5

13 years ago
What about http vs https?  That's not implicit by port 443.

Comment 6

13 years ago
Two options I can see:

1) Make $sitehostname take the full URL path:
     $sitehostname = "https://mytestsite.com:444/";

or 
2) A function looseley based around the following would probably work, where you
keep $sitehostname as

    $sitehostname = "mytestsite.com";

<?
if (isset($_SERVER['HTTPS'] && strtolower($_SERVER['HTTPS']) == 'on'))
{
        $server = 'https://';
}
else
{
        $server = 'http://';
}

$server .= $sitehostname;

if ($_SERVER['SERVER_PORT'] != 80)
{
        $server .= ':' . $_SERVER['SERVER_PORT'] .'/';
}
?>


I suspect the "proxy-safe" version is 1 as you may want to direct users to

    https://www.mysitedomain.com:444/extensions/

where that is squid which forwards to

    http://internaldomain/extensions/

and I'm not entirely sure how the Apache Variables would handle that...

Updated

13 years ago
Target Milestone: 1.0 → 2.0
Mass change - bugs to be read / (re)confirmed.
Assignee: Bugzilla-alanjstrBugs → nobody
Priority: -- → P5

Comment 8

12 years ago
AMO bugspam. Correcting QA contacts on OLD bugs (mozilla.update@update.bugs)

-> Correct QA contact (web-ui@add-ons.bugs)

Filtermeplzkthx
QA Contact: mozilla.update → web-ui

Comment 9

12 years ago
Bugspam makes us be-come druggies
Fa-la-la-la-la, la-la-la-la
Get morgamic some more coffee
Fa-la-la-la-la, la-la-la-la

Updating all the bugs which have "Update" or "UMO" in them.
Summary: update expects the site to be on port 80 → AMO expects the site to be on port 80
Fixed in the remora trunk, which is where we should all be!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.