279165 - Cannot build Sunbird on BeOS

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Sergei Dolgov]

General problem for both BeOS version (netserver and BONE)
is
#ifdef HAVE_STDINT_H
#include <stdint.h>
#endif
in mozilla/calendar/libical/src/libical/icalrecur.c , line 138.
BeOS has inttypes.h

Don't know what place is better to change, configure files with check to 
AC_CHECK_HEADERS(stdint.h inttypes.h)

or just icalrecur.c file with #if defined(BeOS)
-----------
Second poblem is in libxpical and specific for BONE versions of BeOS.
mozilla/calendar/libxpical/token.c
contains
#ifdef XP_BEOS
#include <be/net/netdb.h>
#endif
which is OK only for netserver version.
in case of BONE version all required definitions are in "standard" header files,
so this ifdef must be ommited.

Comment 1

[Mostafa Hosseini]

Bug 279104 fixes this for Sun, a similar fix for BeOS should do.
As for the second problem, libxpical isn't part of the trunk build anymore and
altogether the trunk build is not quite ready for use.
For a functional calendar the SUNBIRD_0_2_BRANCH should be used until the trunk
is ready

Comment 2

[Sergei Dolgov]

Thanks for the quick reply, Mostafa.
Though, i'm unclear about second part (trunk story).
Unfortunately i should recheck sources, to do correct patch, as in my sources 
(nightly tarball Mozilla 1.8b
Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b) Gecko/20050120)
fix for __sun is still missing.
Anyway, that line
http://lxr.mozilla.org/seamonkey/source/calendar/libical/config.h#27
should look like:
#if !defined(XP_WIN32) && !defined(__sun) && !defined(BEOS)

Comment 3

[Mostafa Hosseini]

(In reply to comment #2)
> should look like:
> #if !defined(XP_WIN32) && !defined(__sun) && !defined(BEOS)

Checked in.

Comment 4

[Sergei Dolgov]

Thanks, Mostafa.
Will do checkout at weekend and mark it fixed, if it builds OK.

Comment 5

[Joey Minta]

(In reply to comment #4)
> Thanks, Mostafa.
> Will do checkout at weekend and mark it fixed, if it builds OK.

Sergei,
   Did this bug get resolved or is it still present for you?

Comment 6

[Simon Paquet [:sipaq]]

The first problem has been fixed by a checkin from Mostafah nearly one year ago and the second part has been fixed by obsoleting libxpical.

Comment 7

[Sergei Dolgov]

2006-04-06 cvs trunk
mozilla/calendar/libical/src/libical/icalrecur.c:138: stdint.h: No such file or directory    is the 1st error.

Comment 8

[Sergei Dolgov]

I suspect that maybe there should be XP_BEOS instead BEOS 
in
http://lxr.mozilla.org/seamonkey/source/calendar/libical/config.h#27

Comment 9

[Sergei Dolgov]

Attachment: patch

Adding patch for case if Matt Madia's BeWitched tinderbox will show success with this change.

Comment 10

[Sergei Dolgov]

New  error message after applying first patch config.h to your specifications:    mozilla/calendar/libical/src/libical/icalrecur.c:1954: `intptr_t' undeclared (first use in this function).
So probably line 
http://lxr.mozilla.org/seamonkey/source/calendar/libical/src/libical/icalrecur.c#141 
also needs some correction

Comment 11

[mmadia]

Attachment: modifications needed to build SeaMonkey w/calendar enabled

Adding patch after successfully building SeaMonkey w/Calendar enabled.
Includes changes of previous attachment id 217680.

Comment 12

[Sergei Dolgov]

Comment on attachment 217695 [details] [diff] [review]
modifications needed to build SeaMonkey w/calendar enabled

seems correct from BeOS POV
Wondering if Mostafa is right person for second review

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 217695 [details] [diff] [review]
modifications needed to build SeaMonkey w/calendar enabled

Was this patch tested on any other platforms? The WIN32 -> XP_WIN32 looks useless, and might actually be a risk.

Comment 14

[Sergei Dolgov]

as far as i understand, patch was created looking at libical/config.h where #if define(XP_WIN32) was in use.

If it is risky, I'm for returning to WIN32

Comment 15

[Mostafa Hosseini]

> If it is risky, I'm for returning to WIN32
Please provide patch using WIN32 (to avoid unnecassary risk) and I'll r+

Comment 16

[mmadia]

Attachment: patch

uses WIN32 as requested.

Comment 17

[Mostafa Hosseini]

Comment on attachment 217748 [details] [diff] [review]
patch

r=mostafah

Comment 18

[Sergei Dolgov]

Mostafa, can you also checkin it?

Comment 19

[Simon Paquet [:sipaq]]

Sergei, please note that we will abandon the Calendar extension to the Suite in the coming weeks until the move to mozilla/toolkit has been completed.

So this will be just a temporary solution until the first of our patches regading this goes in.

Comment 20

[Michiel van Leeuwen (email: mvl+moz@)]

Simon: please look at the patches. They are to libical, so will also affect sunbird and lightning.

Comment 21

[Simon Paquet [:sipaq]]

(In reply to comment #20)
> Simon: please look at the patches. They are to libical, so will also affect
> sunbird and lightning.

mvl, sorry that I didn't communicate my message more clearly. My point was not about the patch in question but just a general comment that the "calendar part of suite" (as stated in the bug description) will be broken in a short while.

Comment 22

[Gopal Venkatesan]

stdint.h doesn't exist on FreeBSD 4.x, nor OpenBSD (I'm not sure about NetBSD). Instead, "inttypes.h" needs to be used.

So, the following patch fixes this problem:

--- mozilla/calendar/libical/src/libical/icalrecur.c-ORIG       Wed Feb 16 02:18:26 2005
+++ mozilla/calendar/libical/src/libical/icalrecur.c    Mon May  8 14:04:26 2006@@ -135,7 +135,11 @@
 #endif

 #ifdef HAVE_STDINT_H
+#if defined(__FreeBSD__) || defined(__OpenBSD__)
+#include <inttypes.h>
+#else
 #include <stdint.h>
+#endif
 #endif

 #ifndef HAVE_INTPTR_T

Comment 23

[Gopal Venkatesan]

That can be added to config.h even, thats better I suppose.

Comment 24

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!

Comment 25

[Matthew (lilmatt) Willis]

patch checked in on MOZILLA_1_8_BRANCH and trunk

Thanks for the patch, and sorry for taking so long to get this landed.

-> FIXED