Closed
Bug 279165
Opened 20 years ago
Closed 18 years ago
Cannot build Sunbird on BeOS
Categories
(Calendar :: Internal Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sergei_d, Assigned: sergei_d)
Details
Attachments
(2 files, 1 obsolete file)
729 bytes,
patch
|
Details | Diff | Splinter Review | |
1.28 KB,
patch
|
mostafah
:
first-review+
|
Details | Diff | Splinter Review |
General problem for both BeOS version (netserver and BONE) is #ifdef HAVE_STDINT_H #include <stdint.h> #endif in mozilla/calendar/libical/src/libical/icalrecur.c , line 138. BeOS has inttypes.h Don't know what place is better to change, configure files with check to AC_CHECK_HEADERS(stdint.h inttypes.h) or just icalrecur.c file with #if defined(BeOS) ----------- Second poblem is in libxpical and specific for BONE versions of BeOS. mozilla/calendar/libxpical/token.c contains #ifdef XP_BEOS #include <be/net/netdb.h> #endif which is OK only for netserver version. in case of BONE version all required definitions are in "standard" header files, so this ifdef must be ommited.
Comment 1•20 years ago
|
||
Bug 279104 fixes this for Sun, a similar fix for BeOS should do. As for the second problem, libxpical isn't part of the trunk build anymore and altogether the trunk build is not quite ready for use. For a functional calendar the SUNBIRD_0_2_BRANCH should be used until the trunk is ready
Assignee | ||
Comment 2•20 years ago
|
||
Thanks for the quick reply, Mostafa. Though, i'm unclear about second part (trunk story). Unfortunately i should recheck sources, to do correct patch, as in my sources (nightly tarball Mozilla 1.8b Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b) Gecko/20050120) fix for __sun is still missing. Anyway, that line http://lxr.mozilla.org/seamonkey/source/calendar/libical/config.h#27 should look like: #if !defined(XP_WIN32) && !defined(__sun) && !defined(BEOS)
Comment 3•20 years ago
|
||
(In reply to comment #2) > should look like: > #if !defined(XP_WIN32) && !defined(__sun) && !defined(BEOS) Checked in.
Assignee | ||
Comment 4•20 years ago
|
||
Thanks, Mostafa. Will do checkout at weekend and mark it fixed, if it builds OK.
Comment 5•20 years ago
|
||
(In reply to comment #4) > Thanks, Mostafa. > Will do checkout at weekend and mark it fixed, if it builds OK. Sergei, Did this bug get resolved or is it still present for you?
Comment 6•19 years ago
|
||
The first problem has been fixed by a checkin from Mostafah nearly one year ago and the second part has been fixed by obsoleting libxpical.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•19 years ago
|
||
2006-04-06 cvs trunk mozilla/calendar/libical/src/libical/icalrecur.c:138: stdint.h: No such file or directory is the 1st error.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•19 years ago
|
||
I suspect that maybe there should be XP_BEOS instead BEOS in http://lxr.mozilla.org/seamonkey/source/calendar/libical/config.h#27
Assignee | ||
Comment 9•19 years ago
|
||
Adding patch for case if Matt Madia's BeWitched tinderbox will show success with this change.
Assignee: gray → sergei_d
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 10•19 years ago
|
||
New error message after applying first patch config.h to your specifications: mozilla/calendar/libical/src/libical/icalrecur.c:1954: `intptr_t' undeclared (first use in this function). So probably line http://lxr.mozilla.org/seamonkey/source/calendar/libical/src/libical/icalrecur.c#141 also needs some correction
Comment 11•19 years ago
|
||
Adding patch after successfully building SeaMonkey w/Calendar enabled. Includes changes of previous attachment id 217680.
Assignee | ||
Comment 12•19 years ago
|
||
Comment on attachment 217695 [details] [diff] [review] modifications needed to build SeaMonkey w/calendar enabled seems correct from BeOS POV Wondering if Mostafa is right person for second review
Attachment #217695 -
Flags: second-review?(mostafah)
Attachment #217695 -
Flags: first-review+
Comment 13•19 years ago
|
||
Comment on attachment 217695 [details] [diff] [review] modifications needed to build SeaMonkey w/calendar enabled Was this patch tested on any other platforms? The WIN32 -> XP_WIN32 looks useless, and might actually be a risk.
Assignee | ||
Comment 14•19 years ago
|
||
as far as i understand, patch was created looking at libical/config.h where #if define(XP_WIN32) was in use. If it is risky, I'm for returning to WIN32
Comment 15•19 years ago
|
||
> If it is risky, I'm for returning to WIN32
Please provide patch using WIN32 (to avoid unnecassary risk) and I'll r+
Comment 16•19 years ago
|
||
uses WIN32 as requested.
Comment 17•19 years ago
|
||
Comment on attachment 217748 [details] [diff] [review] patch r=mostafah
Attachment #217748 -
Flags: first-review+
Updated•19 years ago
|
Attachment #217695 -
Attachment is obsolete: true
Attachment #217695 -
Flags: second-review?(mostafah)
Assignee | ||
Comment 18•19 years ago
|
||
Mostafa, can you also checkin it?
Comment 19•19 years ago
|
||
Sergei, please note that we will abandon the Calendar extension to the Suite in the coming weeks until the move to mozilla/toolkit has been completed. So this will be just a temporary solution until the first of our patches regading this goes in.
Comment 20•19 years ago
|
||
Simon: please look at the patches. They are to libical, so will also affect sunbird and lightning.
Comment 21•19 years ago
|
||
(In reply to comment #20) > Simon: please look at the patches. They are to libical, so will also affect > sunbird and lightning. mvl, sorry that I didn't communicate my message more clearly. My point was not about the patch in question but just a general comment that the "calendar part of suite" (as stated in the bug description) will be broken in a short while.
Comment 22•19 years ago
|
||
stdint.h doesn't exist on FreeBSD 4.x, nor OpenBSD (I'm not sure about NetBSD). Instead, "inttypes.h" needs to be used. So, the following patch fixes this problem: --- mozilla/calendar/libical/src/libical/icalrecur.c-ORIG Wed Feb 16 02:18:26 2005 +++ mozilla/calendar/libical/src/libical/icalrecur.c Mon May 8 14:04:26 2006@@ -135,7 +135,11 @@ #endif #ifdef HAVE_STDINT_H +#if defined(__FreeBSD__) || defined(__OpenBSD__) +#include <inttypes.h> +#else #include <stdint.h> +#endif #endif #ifndef HAVE_INTPTR_T
Comment 23•19 years ago
|
||
That can be added to config.h even, thats better I suppose.
Updated•18 years ago
|
Summary: Cannot build Calendar part of suite → Cannot build Sunbird on BeOS
Whiteboard: checkin needed
Updated•18 years ago
|
Component: libical → Internal Components
Comment 24•18 years ago
|
||
The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!
QA Contact: libical → base
Comment 25•18 years ago
|
||
patch checked in on MOZILLA_1_8_BRANCH and trunk Thanks for the patch, and sorry for taking so long to get this landed. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 18 years ago
Resolution: --- → FIXED
Whiteboard: checkin needed
You need to log in
before you can comment on or make changes to this bug.
Description
•