279439 - Creating new application made website not show entries

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

In doing some testing, I created a new value for an app.  When I went to the
site, there were no listings on the website.  We need to figure out what about
this row made this happen and how to prevent it.

INSERT INTO `applications` VALUES (43, 'Firefox', '666', 6, 6, 6, 0, '', '{ec8
030f7-c20a-464f-9b0e-13a3a9e97384}', NULL, 'YES', 'fx');
10712c10713

Comment 1

[Giorgio Maone [:ma1]]

(In reply to comment #0)
> In doing some testing, I created a new value for an app.  When I went to the
> site, there were no listings on the website.  We need to figure out what about
> this row made this happen and how to prevent it.
> 
> INSERT INTO `applications` VALUES (43, 'Firefox', '666', 6, 6, 6, 0, '', '{ec8
> 030f7-c20a-464f-9b0e-13a3a9e97384}', NULL, 'YES', 'fx');
> 10712c10713

The row you inserted *normally* should prevent extensions from showing unless
they are compatible with Firefox 6.6.6 (quite rare objects, at this moment).
Nevertheless, even "compatible" extension will not show because of a real bug,
involving release number not properly concatenated to the version string and
leading to malformed numbers, when other than zero. This bug is duplicated in 7
different files, mostly because of a 'copy & paste' software development
methodology that seems to plague UMO 1.0. Patch coming in minutes.

Comment 2

[Giorgio Maone [:ma1]]

Attachment: Fix for this bug

The same fix to a trivial syntax error applied to 7 different files... :P

Comment 3

[Giorgio Maone [:ma1]]

Attachment: Fix for this bug

The same fix to a trivial syntax error applied to 7 different files... :P

Comment 4

[alanjstr]

Looks good, but can you change it to .=

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 172621 [details] [diff] [review]
Fix for this bug

This patch doesn't appear to solve the problem - however, it's a good thing to
change anyway.	We still need a patch that makes extensions/themes show up when
you have a bogus application.

Comment 6

[Giorgio Maone [:ma1]]

(In reply to comment #5)
> (From update of attachment 172621 [details] [diff] [review] [edit])
> This patch doesn't appear to solve the problem - however, it's a good thing to
> change anyway.	We still need a patch that makes extensions/themes show up when
> you have a bogus application.
>

What do you mean by "bogus" application? On my test site
(http://flex.informaction.com) I've the following data: preloaded applications
(the ones found in old CVS db structure dump), the "bogus" alanjstr row (see bug
report) plus 1 extension (FlashGot) in two versions:


INSERT INTO main VALUES
(3,'{19503e42-ca3c-4c27-b1e2-9cdb2170ee34}','FlashGot','E','2005-01-23
13:58:09','2005-01-28
09:06:36','http://www.informaction.com/mozilla/flashgot/','Enables Mozilla and
Firefox...','0',0,0,'');


INSERT INTO version VALUES
(6,3,'0.4.1',1,1,'0.7','0.7','6.6.6','6.6.6',81,'2005-01-23
13:58:09','2005-01-23 13:58:09','','','YES');
INSERT INTO version VALUES
(7,3,'0.5.7.2',1,1,'0.7','0.7','1.1','1.1',133,'2005-01-28 09:06:36','2005-01-28
09:06:37','http://ftp.mozilla.org/pub/mozilla.org/extensions/flashgot/flashgot-0.5.7.2-fx+mz.xpi','','YES');
INSERT INTO version VALUES
(8,3,'0.5.7.2',1,2,'1.7','1.7','1.8','1.8',133,'2005-01-28 09:06:36','2005-01-28
09:06:37','http://ftp.mozilla.org/pub/mozilla.org/extensions/flashgot/flashgot-0.5.7.2-fx+mz.xpi','','YES');

Both extensions are showing on my test site:
1) FlashGot 0.4.1 on the front page and in "Firefox|Extensions", because it
claims to be compatible with Firefox 666 (and not with Mozilla)
2) FlashGot 0.5.7.2 only in "Mozilla|Extensions", because it is compatible with
Firefox 0.7-1.1 and with Mozilla 1.7-1.8 (1.8 is current Mozilla version).

No other extension is showing simply because I've no data in my db :)
AFAIK this is the expected behaviour, so IMHO attachment 172621 [details] [diff] [review] does fix the bug.

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 172621 [details] [diff] [review]
Fix for this bug

Apparently I did something wrong while testing last night, because this patch
does in fact solve the problem.  Sorry!

Comment 8

[alanjstr]

This has landed on the live site, but not in CVS.  

Comment 9

[Michael Morgan [:morgamic]]

I patched BRANCH and committed.  Just a note:

    $release = "$release.$row[release]";

could have been

    $release = "{$release}.{$row['release']}";

or

    $release = $release.'.'.$row['release'];