In <navigator.js>, remove blacklists support

RESOLVED FIXED in seamonkey2.0a1

Status

SeaMonkey
General
--
trivial
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.0a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

13 years ago
Spun off from bug 200305 comment 19.
(Assignee)

Comment 1

13 years ago
Created attachment 172166 [details] [diff] [review]
(Av1) <navigator.js>

This is bug 200305 (obsoleted) r+/sr+ patch,
updated to current Trunk, and enhanced.

Is |if (pref.getBoolPref("privacy.popups.first_popup"))| wanted,
or could the "set ... false" be done even when unneeded ?

I wonder what having |popupIcon.hidden = true;| in the |for()| achieves ?
(With my little knowledge, it seems invariant...)
(Assignee)

Updated

13 years ago
Assignee: general → gautheri
Status: NEW → ASSIGNED
Attachment #172166 - Flags: review?(neil.parkwaycc.co.uk)
Can you explain what the original code does, and why it can be removed?
(Assignee)

Comment 3

13 years ago
(In reply to comment #2)
> Can you explain what the original code does, and why it can be removed?

From bug 200305:
{{
 ------- Additional Comment #4 From shliang@formerly-netscape.com.tld 
2003-04-02 14:51 PST  [reply] -------

those lines aren't needed anymore anyway because we don't
support blacklists anymore
}}

Would you have an answer to my 2 questions ?
That isn't an explanation. The code doesn't do blacklists. It does something
related to the icon. If you remove the code, i assume you know what you are
doing. (because i don't know exactly what it does, but i do know that
nsIPermissionManager can handle blacklists in theory)
(Assignee)

Comment 5

13 years ago
(In reply to comment #4)
> That isn't an explanation.

Sure;
Only thing I know is that this is what the patch author wrote,
and that its patch was r+/sr+ at the time.

If the situation has changed in the meantime, I hope someone with more knowledge
than I have will say so: I'm only doing the patch work here...

Comment 6

9 years ago
The code that this patches doesn't exist any more => WONTFIX/INVALID
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 7

9 years ago
Indeed, this code (and more) was removed/replaced by bug 393120:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/suite/browser/navigator.js&rev=1.623&mark=1.617

R.Fixed,
though I don't know much about the old code or the new one to comment further.
Depends on: 393120
Resolution: WONTFIX → FIXED
Target Milestone: --- → seamonkey2.0a1
(Assignee)

Updated

9 years ago
Attachment #172166 - Attachment is obsolete: true
Attachment #172166 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.