279479 - In <navigator.js>, remove blacklists support

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

Spun off from bug 200305 comment 19.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <navigator.js>

This is bug 200305 (obsoleted) r+/sr+ patch,
updated to current Trunk, and enhanced.

Is |if (pref.getBoolPref("privacy.popups.first_popup"))| wanted,
or could the "set ... false" be done even when unneeded ?

I wonder what having |popupIcon.hidden = true;| in the |for()| achieves ?
(With my little knowledge, it seems invariant...)

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Can you explain what the original code does, and why it can be removed?

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Can you explain what the original code does, and why it can be removed?

From bug 200305:
{{
 ------- Additional Comment #4 From [e-mail] 
2003-04-02 14:51 PST  [reply] -------

those lines aren't needed anymore anyway because we don't
support blacklists anymore
}}

Would you have an answer to my 2 questions ?

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

That isn't an explanation. The code doesn't do blacklists. It does something
related to the icon. If you remove the code, i assume you know what you are
doing. (because i don't know exactly what it does, but i do know that
nsIPermissionManager can handle blacklists in theory)

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> That isn't an explanation.

Sure;
Only thing I know is that this is what the patch author wrote,
and that its patch was r+/sr+ at the time.

If the situation has changed in the meantime, I hope someone with more knowledge
than I have will say so: I'm only doing the patch work here...

Comment 6

[Philip Chee]

The code that this patches doesn't exist any more => WONTFIX/INVALID

Comment 7

[Serge Gautherie (:sgautherie)]

Indeed, this code (and more) was removed/replaced by bug 393120:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/suite/browser/navigator.js&rev=1.623&mark=1.617

R.Fixed,
though I don't know much about the old code or the new one to comment further.