200305 - In <navigator.js>, JS "Error: popupManager.getEnumerator is not a function". (on clicking "OK" after changing the 'Block unrequested popup windows' checkbox value)

Status: RESOLVED DUPLICATE of bug 221232

(SeaMonkey :: Preferences, defect)

Description

[Serge Gautherie (:sgautherie)]

User-Agent:       Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401
Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401

This one appeared between v1.3 and v1.4a !?


Reproducible: Didn't try

Steps to Reproduce:
(I am not sure of what triggered this error.)

Actual Results:  
[
Error: popupManager.getEnumerator is not a function
Source File: chrome://navigator/content/navigator.js
Line: 171
]


PS:
 *Is there any meta-bug to block for all the Chrome js error bugs around ?
 *Theses bugs do not seem to create any trouble, except they all clutter the
JS.C. output, thus it's quite difficult to find "real" problems.

Comment 1

[Boris Zbarsky [:bzbarsky]]

> except they all clutter the JS.C. output

There's a preference for this; distributors who want to (eg Netscape) can turn
it off.

shliang, this error sounds like something you'd know about...

Comment 2

[Serge Gautherie (:sgautherie)]

Re comment 1:

I assume that you think about 'Debug > Show chrome JavaScript errors and
warnings' UI.


Additions to my Description:

*"meta-bug to block for all": I meant to use it as a tracker in Bugzilla, to
enhance visibility.
*"all clutter the JS.C.": I wanted to point out that unlike (at this point) this
bug which seems new, there are a few longstanding ones which clutter ... while
looking for new (chrome) ones.

Comment 3

[shliang]

reassign

Comment 4

[shliang]

Attachment: patch

the popup pref listener wasn't changed to reflect recent changes to
permissions, but those lines aren't needed anymore anyway because we don't
support blacklists anymore

Comment 5

[jag (Peter Annema)]

Comment on attachment 119216 [details] [diff] [review]
patch

sr=jag

Comment 6

[Serge Gautherie (:sgautherie)]

Will the patch land for v1.4f, or may be in v1.5a ?

Comment 7

[Dave Habben]

Will this land before 1.5 final? 

A few duplicates of this have been found: 208090 and 189869

Comment 8

[Serge Gautherie (:sgautherie)]

*** Bug 208090 has been marked as a duplicate of this bug. ***

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4) Gecko/20030624] (W98SE)

See bug 208090 description for reproductible testcase:
the error happens on clicking "OK" after changing the checkbox value.

Code location in current trunk is
<http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.js#172>.

Bug happens on W95B (description), W98SE (this comment), W2K (bug 208090).

Changing:
*(Component) Browser-General -> Preferences
*(OS) W95 -> W98 [since I upgraded eventually :->]

Asking for 'blocking1.4.x', since there is an approved patch waiting for landing
for months.

Comment 10

[Serge Gautherie (:sgautherie)]

Re comment 7:

I checked your bug 189869 comment 4;
but I guess that that bug is unrelated to this bug, is it not !?

Comment 11

[Dave Habben]

The javascript attached in bug 189869 causes "popupManager.getEnumerator is not
a function" to appear in the Javascript Console. I had thought that fixing the
popup error would resolve the bug with the Javascript and allow the popup window
to appear. I could be wrong on that.

Comment 12

[Serge Gautherie (:sgautherie)]

Re comment 11:

I believe you're right (not wrong);
but see my bug 189869 comment 5:

I would be ready to add "blocks: 189869";
but I didn't find any clue about this in that other bug yet...
(I'd like to experience it myself before acting)

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5b) Gecko/20030827] (W98SE)

Line number update: 171 -> 172
{
Error: popupManager.getEnumerator is not a function
Source File: chrome://navigator/content/navigator.js
Line: 172
}

(Shliang) Still noone to land your 2reviewed patch ??

Comment 14

[Alex Vincent [:WeirdAl]]

Patch has bitrotted; do we still see this error? 

Comment 15

[Adam Hauner]

Repro from bug 208090 WFM - 2004011308/trunk/W2K

Comment 16

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031208] (W98SE)

WorksForMe confirmed :-)

The code was changed in: (bug 221232 is duplicate of current bug !)
{
1.520	mvl%exedo.nl	Oct 31 2003	 	nsIPopupManager.getEnumerator is replaced by
nsIPermissionManager.getEnumerator
bug 221232, r=dwitte, sr=bryner
}

Still, in comment 4, shliang wrote
{
those lines aren't needed anymore anyway because we don't support blacklists anymore
}
jag:
Should I update the patch to remove these lines !?

Comment 17

[Serge Gautherie (:sgautherie)]

Neil:
Could you help answering comment 6 ?

Comment 18

[[e-mail]]

Maybe mvl knows, or maybe we should just resolve this bug as dup of 221232

Comment 19

[Michiel van Leeuwen (email: mvl+moz@)]

The answer to comment 6 is ofcourse 6, given that it didn't happen. And there
isn't anything we can do to change that.
If you mean comment 16, that would be a new bug. The bug as reported here is fixed.

*** This bug has been marked as a duplicate of 221232 ***

Comment 20

[Serge Gautherie (:sgautherie)]

(In reply to comment #19)
> If you mean comment 16, that would be a new bug. The bug as reported here is
fixed.

Yes, I meant comment 16 :-/
I thought this bug could have been morphed; anyway, I filed bug 279479 !