279908 - XUL canvas doesn't build with cairo 0.3.0

Status: RESOLVED INVALID

(Core :: Graphics: Canvas2D, defect)

Description

[David Leverton]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050126 MultiZilla/1.7.0.0f
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050126 MultiZilla/1.7.0.0f

Cairo 0.3.0 (required for Mozilla SVG with Cairo since the checkin in
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=mozilla%2Flayout%2Fsvg%2Frenderer%2Fsrc%2Fcairo&file=&filetype=match&who=&whotype=match&sortby=Date&hours=72&date=explicit&mindate=2005-01-24+09-00-00&maxdate=2005-01-24+10-00-00&cvsroot=%2Fcvsroot,
and will be required for every use of Cairo in Mozilla when bug 279785 is fixed)
places its header files in a subdirectory called "cairo", requiring the app to
add that directory to its include path.  Mozilla's configure script detects the
directory properly, but it doesn't get added to the include path when building
the XUL canvas tag.

Reproducible: Always

Steps to Reproduce:
1. Install Cairo 0.3.0.
2. Attempt to configure and build Mozilla with --enable-cairo

Actual Results:  
The compiler can't find cairo.h when building nsCanvasRenderingContext2D.cpp

Expected Results:  
Shiny new Mozilla build.

Patch coming....

Comment 1

[David Leverton]

Attachment: patch to the Makefile to pick up Cairo include directory

Comment 2

[David Leverton]

Attachment: 2nd attempt

OK, that last one didn't work so well, apologies.  Let's try again....

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 280100 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

Vlad, Pav, would one of you be the right reviwer for this?

Comment 5

[Takeshi Kurosawa :takenspc]

Resolved by bug 289994 ?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 172456 [details] [diff] [review]
2nd attempt

Vlad, is this the right change here?

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 172456 [details] [diff] [review]
2nd attempt

Probably, but I've rewritten all the canvas stuffs in bug 288714, which is just
waiting for some reviews to get checked in.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Well, note that it's been two months since you were first asked about the
changes in this bug.... Good to finally have a response, though. :(

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hmm, oops :(  Redid my bug mail setup a month or two ago to try to make sure I
didn't miss important stuff, sorry 'bout that!

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

When this gets fixed, you should back out the change in bug 289994.

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Obsoleted by HTML Canvas