This was 'inspired' by bug 280001 and many others just like that. One of the most confusing aspects of Mozilla font-pref. UI is what 'font pref. entries for Unicode' are for. Currently, they're only used to set fonts for langGroups for which we don't have separate font pref. entries (e.g. Ethiopian, Bengali, etc).(bug 256383) It's NOT for setting fonts for pages in UTF-8/16/32 *without* lang, but users often get confused by that as shown by bug 280001 and others.  Having said that, I think we may not have to fix bug 91190. Instead, we may as well just rename 'Unicode langGroup' to 'Other scripts/languages'. Actually, bug 91190 and renaming are rather orthogonal to each other. So, we have to do both, but independently of each other.  In UTF-8/16/32 pages (and to a lesser degree in pages in non-Unicode encoding), it's always a good idea to specify 'lang' and/or 'xml:lang'. See http://www.w3.org/International/resource-index.html#lang.
Created attachment 173453 [details] [diff] [review] patch (UI name change) I just changed the UI name, but didn't change our internal names ('x-unicode', 'langGroup.unicode',etc). I can do that, but I don't think it's necessary (it'll be a huge patch). What do you think?
Created attachment 173454 [details] [diff] [review] help file patch I added a sentence about 'Other languages'. While I'm at it, I also fixed FF help (I thought I fixed it while working on the suite help, but apparently I didn't).
Attachment #173454 - Flags: review?(steffen.wilberg)
Comment on attachment 173454 [details] [diff] [review] help file patch r=me if you actually change the entity string from "Unicode" to "Other languages" in http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/pr0. Your first patch only changes xpfe and mail. And please use <em> instead of <q> in Firefox Help.
Attachment #173454 - Flags: review?(steffen.wilberg) → review+
Created attachment 173455 [details] [diff] [review] patch (UI name change) : missing browser part added I forgot to include browser/* part in the previous patch. (thanks Steffen for catching that.) Do I need to ask a FF peer for review as well?
Attachment #173455 - Flags: review?(smontagu) → review+
"For codebase-wide simple, repetitive changes (such as relicensing, spelling, whitespace or capitalization changes), review from a Firefox Peer is not required as long as the patch as a whole has review." http://www.mozilla.org/projects/firefox/review.html This is a codebase-wide (xpfe, mail, browser), simple (change of a single entity), and repetitive (xpfe, mail, browser) change, isn't it? ;-)
14 years ago
Attachment #173455 - Flags: superreview?(dbaron) → superreview+
thanks for r/sr. landed on the trunk
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.