280028 - When editing a bookmark name/URL inline, undo should undo editing, not undo add bookmark

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, defect, P3)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Camino 2005012608 (v0.8+)

Most of the time when editing the text of a bookmark's title or its URL inline
(ie, there are certain conditions I haven't quite deciphered yet that don't
cause this), cmd-z is "Undo Add Bookmark" and removes the selected bookmark
instead of backing out any inline edit!  The key-command user is not going to
realize that cmd-z is undoing the addition of a bookmark...

(This doesn't happen when using the "Get Info" method of editing, where the
cmd-z menu item accurately reflects Undo Typing)

I've just now switched back to typing this bug and the title of Cmd-z still says
"Undo Add Bookmark", although cmd-z seems to undo a deletion in the text box. 
Something strange is going on.... :-)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Chris, I don't know if this code is near anything you're touching now or not?  If not (and not near bug 313740 either), we should prolly push this to 1.1.

Comment 2

[Samuel Sidler (old account; do not CC)]

-> 1.1

Comment 3

[John Bailey]

I figure I'll throw this in here since you can probably fix it at the same time;
A regression with not being able to Edit-Undo when making a change to the BM Bar.  You have to first bring the manager into view, then the "Undo" name will reflect the action and actually work.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Esc does not cancel uncommited inline edits, either.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Wevah, can you look in to this?

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.