280232 - Search crashes on working with address book from sidebar [@ nsCSubstring::ReplacePrep ][@ nsCharTraits<char>::compareLowerCaseToASCIINullTerminated(char const*, unsigned int, char const*)]

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Vedran Miletic]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b) Gecko/20050127
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b) Gecko/20050127

I tried to find an open duplicate for this, but nothing was similar enough and a
good report too. So, I filed a bug.

I noticed that operating Address book from Sidebar can lead to crashes.

Reproducible: Sometimes

Steps to Reproduce:
I haven't found a way to reproduce it, but editing, deleting, searching,
anything can trigger it, but not always.
Actual Results:  
Crash.

Expected Results:  
I think it shouldn't crash.

TB3352226Z (on find), TB3351981E (on delete)

My abook.mab is copied from Thunderbird profile, but I think it should be
compatible(?).

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

nsCSubstring::ReplacePrep 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/string/src/nsTSubstring.cpp,
line 195]
nsCSubstring::Assign 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/string/src/nsTSubstring.cpp,
line 311]
nsCSubstring::Assign 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/string/src/nsTSubstring.cpp,
line 371]
nsCharsetAlias2::GetPreferred 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/intl/uconv/src/nsCharsetAliasImp.cpp,
line 74]
nsCharsetConverterManager::GetCharsetAlias 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/intl/uconv/src/nsCharsetConverterManager.cpp,
line 384]
nsCharsetConverterManager::GetUnicodeDecoder 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/intl/uconv/src/nsCharsetConverterManager.cpp,
line 238]
nsTextToSubURI::UnEscapeAndConvert 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/intl/uconv/src/nsTextToSubURI.cpp,
line 138]
nsAbQueryStringToExpression::CreateBooleanConditionString 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp,
line 327]
nsAbQueryStringToExpression::ParseCondition 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp,
line 207]
nsAbQueryStringToExpression::ParseExpression 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp,
line 130]
nsAbQueryStringToExpression::ParseExpressions 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp,
line 159]
nsAbQueryStringToExpression::ParseExpression 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp,
line 118]
nsAbQueryStringToExpression::Convert 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp,
line 64]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 902]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]
nsAbDirectoryQuery::query 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 380]
nsAbDirectoryQuery::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 355]
nsAbDirectoryQueryProxy::DoQuery 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQueryProxy.h,
line 49]
nsAbMDBDirectory::StartSearch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 944]
nsAbMDBDirectory::GetChildCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 373]
nsAbDirectoryQuery::queryCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbDirectoryQuery.cpp,
line 430]

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

The stack in comment 1 is from search, but the stack below is from deletion of
two contiguous addressbook entries using the context menu item in the sidebar,
and both of these are separate bugs.

Mark, I'm not sure if/how you want to deal with these two bugs.

nsAbMDBDirectory::RemoveCardFromAddressList 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 95]
nsAbMDBDirectory::DeleteCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbMDBDirectory.cpp,
line 535]
nsAbView::DeleteSelectedCards 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/addrbook/src/nsAbView.cpp,
line 1109]
XPTC_InvokeByIndex 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 102]
XPCWrappedNative::CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2034]
XPC_WN_CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1287]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1293]
js_Interpret 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 3565]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1313]
js_InternalInvoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1390]
JS_CallFunctionValue 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsapi.c, line
3804]
nsJSContext::CallEventHandler 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/dom/src/base/nsJSEnvironment.cpp,
line 1352]
nsJSEventListener::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/dom/src/events/nsJSEventListener.cpp,
line 184]
nsEventListenerManager::HandleEventSubType 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1519]
nsEventListenerManager::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1596]
nsXULElement::HandleDOMEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2035]
PresShell::HandleDOMEventWithTarget 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/base/nsPresShell.cpp,
line 5998]
nsMenuFrame::Execute 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsMenuFrame.cpp,
line 1620]
nsMenuFrame::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsMenuFrame.cpp,
line 446]
PresShell::HandleEventInternal 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/base/nsPresShell.cpp,
line 5963]
PresShell::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/base/nsPresShell.cpp,
line 5775]
nsViewManager::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 2424]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 2151]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1103]
nsWindow::DispatchMouseEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 5402]
ChildWindow::DispatchMouseEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 5653]
nsWindow::WindowProc 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1389]
USER32.dll + 0x8709 (0x77d48709)
USER32.dll + 0x87eb (0x77d487eb)
USER32.dll + 0x89a5 (0x77d489a5)
USER32.dll + 0x89e8 (0x77d489e8)
nsAppShell::Run 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsAppShell.cpp,
line 159]
nsAppStartup::Run 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/components/startup/src/nsAppStartup.cpp,
line 208]
main 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1811]
WinMain 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1839]
kernel32.dll + 0x16d4f (0x7c816d4f)

Comment 3

[timeless]

note that at least one of these is listed as stack overflow

Comment 4

[Mark Banner (:standard8)]

Note: similar crash for deleting items is bug 203744.

The deletion bug has lots of similar talkback data especially for TB - 135 in TB
1.0 since 10/01/05. Looks like there is an easy fix for that one, but would like
 to spend a little while trying to see why it's happening first.

Still need to look into the find one.

 

Comment 5

[Mark Banner (:standard8)]

Ok, I've had a look at both crashes in some detail, I have moved the delete
crasher out to bug 280463 as it's significant and now I have a test case for it,
should be fairly easy to fix.

This one I haven't been able to reproduce yet, but it looks like we end up
starting a search on a queried directory, which then queries another query
directory (may be itself) and so forth just circuling round, hence the stack
overflow.

Comment 6

[Mark Banner (:standard8)]

Talkback is still seeing this & in Thunderbird (on Mac -> All), moving to core.

Comment 7

[Wayne Mery (:wsmwk)]

still (but very few) on talkback in thunderbird 2.0.0.6 with nsCSubstring::ReplacePrep 

those with comments...

TB33152240 - 1. Create New message 2. Paste text from the following page: http://www.trackstudio.ru/forum/bug-tracking-old-scm-integration-issue-1951.html (the first post, 4th line, from ':' to end of line) a). to 'To:' address b). to message body 3. Crash

TB33505293 - searchin an address

TB34170935 - Click "Send" and Thunderbird put into "Draft". Cannot find "Draft" to open_How do I do that.

Comment 8

[Keith Mawdsley]

Hi I have a post in the news group about this. I exported my address book as a .csv - cleaned it up in a spreadsheet and as I don't use this for my contact numbers I only have entries in the first name, last name, display name, email and company fields. Once cleaned up I saved it back to csv - deleted my TB address book and re imported from the csv. It still crashes. More often than not if I send an attachment from Acrobat I click the email icon which launches a mail window with the attachment. I then search on company (or name) for the recipient and more often than not it will crash. If you open a mail - I tried search-delete-search-delete-search before it crashed (that is deleting the search text not the mail). Re-launched and tried again this time at least 10 searches without a crash. try looking for an initialised variable, could be the cause of this intermittent behaviour. Running a brand new HP machine with vista - was also doing it on my 5 year old machine with 2000.

Comment 9

[Wayne Mery (:wsmwk)]

Keith, can you list the steps to reproduce as
1. ___
2. ___
etc.

Comment 10

[Keith Mawdsley]

Steps to reproduce:

1. compose new mail
2. in the sidebar type company name
3. crash
4. relaunch thunderbird
5.scream ;D

Only occasionally it works, most times it crashes.

Comment 11

[Keith Mawdsley]

*** 2. in the sidebar type company name <<<< don't need to press enter just crashes

Comment 13

[Keith Mawdsley]

as an update to my post. I don't often use this feature now due to the problem however on the occasions I have used it it has worked fine. I am now running TB 2.0.0.23 (20090812) I haven't done anything to 'cure' it - it is possible an update has though? I shall start using it again and see.

Comment 14

[Mark Banner (:standard8)]

(In reply to comment #13)
> as an update to my post. I don't often use this feature now due to the problem
> however on the occasions I have used it it has worked fine. I am now running TB
> 2.0.0.23 (20090812) I haven't done anything to 'cure' it - it is possible an
> update has though? I shall start using it again and see.

We've not changed anything afaik, we don't know what causes it either so it is hard to say. I'm looking at a workaround for the Thunderbird 3 builds I don't know if that will be sufficient to "fix" it or not.

Comment 15

[Mark Banner (:standard8)]

Attachment: Possible workaround

I've looked at this several times in the past few years and still worked out what is causing this to fail.

What we're meant to do is:

1 Get nsAbMDBDirectory with a query URI
2 Get its child cards
2a As its a query URI, call StartSearch
2b In StartSearch, get the nsIAbDirectory *without* the query
2c Search in the nsIAbDirectory by
2ca Get its child cards
2cb sort through the child cards.

What appears to be happening when we are in the loop is at 2ca we've got a nsAbMDBDirectory that is based on a query URI, hence we go back to step 2a and repeat.

Therefore I'm proposing that if in StartSearch we've got a directory that is a query, just abort the search. This should at least prevent the crash, and if we get some reports of weird search results, then we can hopefully encourage the reporters to give us more details and maybe find the cause.

I've put an assertion in, but if we need more info, we could probably use nsIConsoleService if we feel we can get useful information from users - but I think lets just see how the patch goes for now.

Comment 16

[shane]

I have a SIMILAR issue running Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.4pre) Gecko/20090825 Shredder/3.0b4pre on Windows 7 Build 7100 when I tab from the TO: field after it has auto completed.  The system is fine if I click on another field, and is fine if I don't autocomplete, but I can crash it 100% of the time by autocompleting the TO: Field and then tabbing.

Comment 17

[Mark Banner (:standard8)]

Fix checked in to the Thunderbird 3 builds: http://hg.mozilla.org/comm-central/rev/781e0426972f

Tentatively calling fixed, we'll see what happens in crash-stats.