280463 - Crash on delete from address book sidebar after search [@ nsAbMDBDirectory::RemoveCardFromAddressList ]

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Mark Banner (:standard8)]

I have extracted this from bug 280232 about random crashes in the sidebar as
essentially there were two bugs in one, that appear unrelated so I wanted to be
able to handle them seperately.

This is the delete card part of that crash, talkback ID: TB3351981E, and many
others from looking at the talkback server - affecting thunderbird 1.0, and more
recently MAS trunk.

I have found one way to reproduce, which may or may not be the only way:

1) Ensure address book has a card in it which is also in a mail list.
2) Start up browser and open the address book sidebar (i didn't have the normal
address book open)
3) Select the appropriate address book.
4) Search for a card - my search was one letter which happened to match all my
cards (and the list)
5) Clear the search
6) select the card that is in mail list, right click -> delete.

Actual Results: Mozilla crashes.
Expected results: Card to be deleted correctly.

Note: I can replicate this in the same fashion with Thunderbird and the contacts
panel when writing a message.

Comment 1

[Mark Banner (:standard8)]

Attachment: Stack Track from TB Server id: TB3351981E

Adding stack trace from talkback server

Comment 2

[Mark Banner (:standard8)]

Attachment: Patch to fix crash and bug 152133

This patch fixes the crash in the address book by checking for null pointers,
and then also trying to cope with the address list not having been initialised
by calling it.

I have also added the fix from the patch on bug 152133 as that fixes an issue
with deleting cards which are also in mailing lists and seemed relevant to this
patch. See my attachement comment on that bug for some of the rational behind
the 152133 fix (https://bugzilla.mozilla.org/show_bug.cgi?id=152133#c7).

Comment 3

[Mark Banner (:standard8)]

Scott, if you sr+ this patch, could you also check it in for me as well please?
Thanks.

Comment 4

[Mark Banner (:standard8)]

This crasher happens frequently on TB, and occasionally on Mail News. I'd like 
to suggest we get it in before 1.1 of TB.

Comment 5

[Mark Banner (:standard8)]

Scott any chance of an sr on this crasher sometime? It'd be good to get it in
before the next set of releases. Thanks.

Comment 6

[Mark Banner (:standard8)]

Fix checked in by timeless:
2005-03-02 10:24	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ src/
nsAbMDBDirectory.cpp 	1.43 	25/2 

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED for me with build 2005-03-03 using Windows XP Seamonkey trunk.