281572 - Add Thunderbird Extension: compactfolder

Status: RESOLVED DUPLICATE of bug 286765

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mark Edgington]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.1.4322)
Build Identifier: 

Please consider adding the compactfolder extension to the updates.mozilla.org 
website.  The URL for the xpi file is
http://downloads.mozdev.org/compactfolder/compactfolder_0.0.1.xpi

The homepage URL is http://compactfolder.mozdev.org

It should be compatible with Thunderbird 1.0.  I have only tested it with a 
fresh install using the default theme and English as the locale.  I make no 
guarantees that it works with other configurations, but hopefully it does.



Reproducible: Always

Steps to Reproduce:

Comment 1

[Alex Sirota (iosart)]

compactfolder 0.0.1: install, basic functionality, uninstall tested on Win98SE,
TB 1.0

Comment 2

[alanjstr]

For some reason, UMO doesn't like it.  You'll have to wait until we fix whatever
bug it is that makes this happen.

Comment 3

[alanjstr]

Error! The MaxAppVer for Thunderbird of 1.5 in install.rdf is invalid.

Try 1.0

Comment 4

[Mark Edgington]

Ok... the max version has been updated.  See the compactfolder 0.0.2 xpi.

As a side note, it would be nice if there was a way that developers could avoid 
having to update their extensions every time a new TB release comes out.  (even 
if new TB releases aren't so frequent)

Comment 5

[alanjstr]

I can change the maxVersion on the website without you having to roll a new XPI.
 Once we let developers in, you can do so yourself.

Comment 6

[Mark Edgington]

From the addons.update.mozilla.org website, the "install now" button fails.  It 
says that the URL is invalid -- is there a problem with this link?

Comment 7

[alanjstr]

Lookslike a valid link to me.
https://addons.mozilla.org/core/install.php?passthrough=yes&uri=http://ftp.mozilla.org/pub/mozilla.org/extensions/compact%20folder%20button/compact_folder_button-0.0.2-tb.xpi

Comment 8

[Mark Edgington]

Yes, it *looks* valid, but when it is clicked on, the message "Invalid URI 
cannot Continue" is all that shows on the screen.  I've looked at the code for 
install.php ( 
http://lxr.mozilla.org/mozilla/source/webtools/update/core/install.php ), and 
see nothing outrageous in it.  I suspect, therefore, that perhaps the URI is 
improperly listed in the database, and that as a result no rows match the query.

The relevant code from install.php is:

//Get Full Information for the file requested.
$uri = escape_string(str_replace(" ","+",$_GET["uri"]));
$sql = "SELECT `vID`, TM.ID, `URI` FROM `version` TV INNER JOIN `main` TM ON 
TM.ID=TV.ID WHERE `URI`='$uri' LIMIT 1";
$sql_result = mysql_query($sql, $connection) or trigger_error("MySQL 
Error ".mysql_errno().": ".mysql_error()."", E_USER_NOTICE);
if (mysql_num_rows($sql_result)=="0") {
  exit("Invalid URI cannot Continue");
}

Comment 9

[Mark Edgington]

It turns out to be a problem with the PHP code, and not the database.  I was 
informed that this problem is dealt with in bug #286765.  So, I'm closing this 
bug as a duplicate.


*** This bug has been marked as a duplicate of 286765 ***

Comment 10

[Michael Morgan [:morgamic]]

AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)