281910 - Links from l10n lxr to l10n bonsai and vice versa are broken

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Axel Hecht]

Chase, I guess you have this on your list, just wanted to get rid of it on mine.

The links from bonsai-l10n to lxr have an /l10n/ too much, 
http://lxr.mozilla.org/l10n/source/l10n/pl-PL/toolkit/defines.inc should be
http://lxr.mozilla.org/l10n/source/pl-PL/toolkit/defines.inc
(found on
http://bonsai-l10n.mozilla.org/cvslog.cgi?file=l10n/pl-PL/toolkit/defines.inc&rev=&root=/l10n)

The opposite way around, the bonsai links on lxr should link to bonsai-l10n and
use a tld of l10n instead of mozilla.

Comment 1

[Daniel de Wildt]

The lxr-link for the non localized bonsai (http://bonsai.mozilla.org) is also
broken. Example:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsTextFrame.cpp
The lxr-link contains a "/mozilla" too much. 
(Or is this an other bug?)

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

another. We're working on l10n webtools.

Comment 3

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 4

[Axel Hecht [:Pike]]

So one aspect of this is that bonsai-l10n doesn't recognize /l10n to be it's top-level-ignore directory.
I found that config var a few days back, but not right now. Anyone with that config var at their finger tips?

Comment 5

[Dave Miller [:justdave]]

(In reply to comment #4)
> So one aspect of this is that bonsai-l10n doesn't recognize /l10n to be it's
> top-level-ignore directory.
> I found that config var a few days back, but not right now. Anyone with that
> config var at their finger tips?

fixed.  mozilla/ has been changed to l10n/ in the params for bonsai-l10n.

That fixed trunk, but not branches.  Bonsai has no concept of branches living at a different lxr_base

Comment 7

[Reed Loden [:reed]]

Is there a reason why this was moved to Server Operations? I don't think there's anything for us to do here.

Comment 8

[u60234]

Updating summary. The remaining problem is LXR -> Bonsai.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Dave: Tara says that if she can get access to the server, she can take a look at this bug.  Can you hook her up?

Comment 10

[Axel Hecht [:Pike]]

This is still there, with mxr being slightly better than lxr.

http://lxr.mozilla.org/l10n/source/pl/toolkit/defines.inc links to
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/pl/toolkit/defines.inc&rev=HEAD&mark=1.1, i.e., wrong bonsai instance and wrong top-level dir, http://mxr.mozilla.org/l10n/source/pl/toolkit/defines.inc links to http://bonsai-l10n.mozilla.org/cvslog.cgi?file=/l10n/mozilla/pl/toolkit/defines.inc&rev=HEAD&mark=1.1, which is almost right, just that the /mozilla/ second top-level dir shouldn't be there.

Links from bonsai-l10n to lxr are broken, too. It's linking back to http://lxr.mozilla.org/l10n/source//l10n/pl/toolkit/defines.inc instead of http://lxr.mozilla.org/l10n/source/pl/toolkit/defines.inc, no second /l10n/.

Comment 11

[Reed Loden [:reed]]

(In reply to comment #10)
> http://lxr.mozilla.org/l10n/source/pl/toolkit/defines.inc links to
> http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/pl/toolkit/defines.inc&rev=HEAD&mark=1.1,
> i.e., wrong bonsai instance and wrong top-level dir,
> http://mxr.mozilla.org/l10n/source/pl/toolkit/defines.inc links to
> http://bonsai-l10n.mozilla.org/cvslog.cgi?file=/l10n/mozilla/pl/toolkit/defines.inc&rev=HEAD&mark=1.1,
> which is almost right, just that the /mozilla/ second top-level dir shouldn't
> be there.

mxr has been fixed. We're not doing any more work on lxr besides keeping it going, so lxr won't/can't be fixed.

> Links from bonsai-l10n to lxr are broken, too. It's linking back to
> http://lxr.mozilla.org/l10n/source//l10n/pl/toolkit/defines.inc instead of
> http://lxr.mozilla.org/l10n/source/pl/toolkit/defines.inc, no second /l10n/.

bonsai-l10n has been changed to use mxr and the regex has been fixed to strip out "/l10n/".

This looks fixed to me. Please reopen if something still isn't correct.