sync xpfe menu.xml with toolkit menu.xml

RESOLVED WONTFIX

Status

()

Core
XUL
RESOLVED WONTFIX
13 years ago
11 years ago

People

(Reporter: mconnor, Assigned: WeirdAl)

Tracking

(Depends on: 1 bug)

Trunk
mozilla1.9alpha1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

13 years ago
 
(Reporter)

Updated

13 years ago
Blocks: 282177

Updated

13 years ago
URL:
Depends on: 221824
Created attachment 176660 [details] [diff] [review]
2005.03.08 X2T diff report

Diff from Xpfe to Toolkit version.

These came from Toolkit versions
{{
1.8	mozilla.mano%sent.com	2005-02-20 07:49		Bug 221824 -
Winstripe should be RTL compatible. patch by kmgerich and me r=kmgerich/mconnor

1.5	bsmedberg%covad.net	2004-10-02 18:19		Bug 221824,
part 2, add content hooks for submenu expander and back/forward buttons.
r=mconnor
}}
(Assignee)

Comment 2

12 years ago
I'd be willing to take a look at this.
Created attachment 222894 [details] [diff] [review]
Current Diff (2006.05.22)

(v1-19_XPFE -> v1-10_TK)
Attachment #176660 - Attachment is obsolete: true
Depends on: 299480
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Comment 4

12 years ago
Created attachment 227293 [details] [diff] [review]
patch, v1

Okay, so the diff between toolkit and xpfe here is mainly about adding a chromedir attribute, gathered from chrome://global/locale/global.dtd.  This is built from dom/locales/jar.mn, and is included in SeaMonkey trunk builds.  The entity itself is in dom/locales/en-US/chrome/global.dtd.
Assignee: nobody → ajvincent
Status: NEW → ASSIGNED
Attachment #227293 - Flags: superreview?(neil)
Attachment #227293 - Flags: review?(neil)
(Assignee)

Comment 5

12 years ago
Created attachment 227317 [details] [diff] [review]
alternative patch

This patch more closely resembles the toolkit transition plan, in that toolkit's menu.xml supersedes xpfe's in xpfe's jar.mn.  As I understand things, the toolkit transition is for trunk code only.  Per my earlier comments, I feel there is no harm in using toolkit's menu.xml now.
Attachment #227293 - Attachment is obsolete: true
Attachment #227317 - Flags: superreview?(neil)
Attachment #227317 - Flags: review?(neil)
Attachment #227293 - Flags: superreview?(neil)
Attachment #227293 - Flags: review?(neil)
(Assignee)

Comment 6

12 years ago
<Neil> all it does is add an attribute we don't use, so I don't see the point

The differences between xpfe and toolkit are so minor that it's not felt to be worth patching.  Closing as WONTFIX; if you disagree, convince the reviewers.  :)
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

12 years ago
Attachment #227317 - Flags: superreview?(neil)
Attachment #227317 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.