282177 - resync xpfe bindings with toolkit widgets

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mike Connor [:mconnor]]

As part of the seamonkey-on-xulrunner work, we need to resync xpfe's bindings
with toolkit's widgets.  Added benefits to both sides will be picking up fixes
that have occured on one side of the fork or the other.  Right now, 13 are still
synced, not counting a couple with whitespace-only differences, and 15 have
differences to be merged.

As part of the process, we can use relative paths in the xpfe jar.mn to pick up
the toolkit versions of synced files, and cvs remove the xpfe versions.  The
xpfe files will always be there in the attic if we need them for cvs blame etc.

There's some issues to be resolved on the non-code level wrt code review as
well, but that's something that needs some discussion with xpfe and toolkit owners.

The following files are already in sync and we can start with them once the
non-code issues are resolved appropriately:
checkbox.xml, colorpicker.xml, editor.xml, groupbox.xml, menulist.xml,
nativescrollbar.xml, popup.xml, progressmeter.xml, scrollbar.xml, scrollbox.xml,
spinbuttons.xml, splitter.xml, stringbundle.xml

Comment 1

[Mike Connor [:mconnor]]

radio.xml is just a blank line before a return statement, so that's 14.

Comment 2

[Benjamin Smedberg]

Didn't BZ file an identical bug to this one a couple months back?

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Somebody unsync'ed colorpicker.xml

Comment 4

[:Gavin Sharp [email: [e-mail]]]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=colorpicker.xml&filetype=match&date=explicit&mindate=2005-02-25+01%3A07&maxdate=2005-02-25+01%3A07&cvsroot=%2Fcvsroot

Comment 5

[Robert Kaiser]

SeaMonkey works fine using the toolkit widgets (code-named "suiterunner"). 

Our intention is to flip the switch very soon and build the trunk suite on toolkit, so that xpfe loses its last big user. 

Improvements that have been done on the xpfe side might still be good to be ported over to their toolkit counterparts so that they aren't lost - porting in the other direction doesn't make sense any more, we'll just let xpfe die without toolkit's improvements ;-)

Could someone sort out the dependencies here that can just be closed out going this direction?

Comment 6

[Robert Kaiser]

is there still something in the widgets area that needs to be ported from xpfe to toolkit that is not tracked by bugs in the dependency list of this one? If so, we should file that soon as we'd like to kill xpfe ASAP.

Comment 7

[Matthias Versen [:Matti]]

XPFE is dead and all depending bugs are fixed

Comment 8

[Philip Chee]

Matti, I think Bug 285374 is still open. It's a one line fix. Serge, do you want to take it?

Comment 9

[Matthias Versen [:Matti]]

you are right and I need glasses

Comment 10

[Matthias Versen [:Matti]]

and it's now really fixed :-)