282185 - Global notifications for completed downloads

Status: RESOLVED FIXED

(Toolkit :: Downloads API, enhancement)

Description

[Brian Schack]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0 StumbleUpon/1.999
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0 StumbleUpon/1.999

When a download is completed on the Macintosh, Firefox should post a Growl
notification. Firefox Mac OS X does not have the download completion
notifications that Firefox for Windows does. If you register the notifications,
then the UI for turning it on and off and customizing it is in Growl.

You might be cautious about implementing platform-specific features, but
implementing the notifications in AppleScript (for example) looks simple to an
outsider, and they could go a long way towards making Mac users feel special.

- Growl (http://growl.info/)
(http://www.drunkenblog.com/drunkenblog-archives/000341.html)
- Growl is licensed under a BSD-style license
(http://growl.info/documentation/Growl-Main-License.txt).
- Documentation (http://growl.info/documentation/)
- Implementing Growl in Carbon applications
(http://growl.info/documentation/implementing-growl.php?lang=carbon)
- Self-proclaimed hack that does this
(http://www.mrchucho.net/index.php/archives/2004/12/27/firefox-and-growl/)

Thank you.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Mike Connor [:mconnor]]

I don't know if we'd add core code to support a third-party OS-specific
function.  That seems a tad bloaty, not to mention I don't know if we can use
AppleScript yet.

Comment 2

[Brian Schack]

In case there was some confusion, Growl supports lots of languages besides AppleScript.

Comment 3

[Asaf Romano (gone)]

We're not going to mess with third party apps; any sort of dock notification is
a better way to go.

Comment 4

[Brian Schack]

This would not make Firefox bloated:
1) It can be implemented without any Firefox UI.
2) It's not slow.

Comment 5

[Chris Forsythe]

If we could do this via an extension that would work, but from what I've seen 
the only extension types are via javascript, which limits this functionality 
very much.

(In reply to comment #3)
> We're not going to mess with third party apps; any sort of dock notification 
is
> a better way to go.

Comment 6

[Ralph M. Churchill]

I've implemented an extension that interfaces with Growl. It's sub-optimal
because, apparently, NSIProcess.run won't accept being passed arguments on Mac
OS X. Otherwise, we could simply pass "Download Complete" and the filename to
growlnotify.

So, the extension is ready -- we just need that bug fixed!

(In reply to comment #5)
> If we could do this via an extension that would work, but from what I've seen 
> the only extension types are via javascript, which limits this functionality 
> very much.

Comment 7

[Chris Forsythe]

Sorry to comment twice. I'm new to this tracker,heh.

The reason why a dock notification is not enough is that dock notifications are 
quite annoying, whereas Growl notifications are very controllable by the user. 
Please try Growl with GrowlSafari, as it would be comparable to what the person 
in this ticket is requesting.


(In reply to comment #3)
> We're not going to mess with third party apps; any sort of dock notification 
is
> a better way to go.

Comment 8

[M-Rick]

It is possible I think to implement Growl in  Firefox by using an xpi extension
that calls Growls through its terminal growlnotify plug-in. 

http://growl.info/documentation/growlnotify.php

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

fwiw, Growl's become a more and more prominent OS X add on, and there seem to be more applications for Mac that support it. Worth re-evaluating?

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Also note bug 308552, bug 332637, and bug 362685.

Comment 11

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

This can't be checked in until the bug this depends on is checked in.  Also, the downloadIcon.png file from toolkit/themes/winstripe/downloads to toolkit/themes/pinstripe/mozapps/downloads

Comment 12

[Asaf Romano (gone)]

Comment on attachment 257044 [details] [diff] [review]
v1.0

You'll need mconnor's approval to land this.

Comment 13

[Shawn Wilsher :sdwilsh]

> This can't be checked in until the bug this depends on is checked in.

I lied.  After thinking about this I realized it will behave the same as if Growl wasn't installed with the other bug landing.

Comment 14

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

As per discussion with mconnor on irc.

Comment 15

[Asaf Romano (gone)]

Comment on attachment 261564 [details] [diff] [review]
v1.1

r=mano.

Comment 16

[Mike Connor [:mconnor]]

Comment on attachment 261564 [details] [diff] [review]
v1.1

ui-r=mconnor

Comment 17

[Shawn Wilsher :sdwilsh]

Please note that whoever checks this in will also have to pull the winstripe file into the proper location in pinstripe:
http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/mozapps/downloads/downloadIcon.png

Comment 18

[Shawn Wilsher :sdwilsh]

Checking in browser/app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.175; previous revision: 1.174
done
Checking in toolkit/themes/pinstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.17; previous revision: 1.16
done
RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloadIcon.png,v
done
Checking in toolkit/themes/pinstripe/mozapps/downloads/downloadIcon.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloadIcon.png,v  <--  downloadIcon.png
initial revision: 1.1
done